Closed
Bug 929067
Opened 11 years ago
Closed 11 years ago
Canceling a download from the Downloads Panel sometimes pauses it instead
Categories
(Toolkit :: Downloads API, defect)
Toolkit
Downloads API
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: Paolo, Assigned: Paolo)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
This was observed in bug 922137:
- Download http://www.softpedia.com/dyn-postdownload.php?p=84329&t=4&i=1
- Cancel the download from the Downloads Panel
- Restart the download, then cancel it again
Sometimes, the download goes to the "paused" state instead of the "canceled" state.
|
Assignee | |
Comment 1•11 years ago
|
||
This was caused by a race condition in the functions that handle asynchronous progress updates, that set hasPartialData to true again after it had been cleared by removePartialData.
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Attachment #8335599 -
Flags: review?(enndeakin)
|
||
Updated•11 years ago
|
Attachment #8335599 -
Flags: review?(enndeakin) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
||
Comment 3•11 years ago
|
||
had to backout this change in https://hg.mozilla.org/integration/fx-team/rev/b4284cae2bff because of test failures after this checkin like https://tbpl.mozilla.org/php/getParsedLog.php?id=31373611&tree=Fx-Team
|
|
Assignee | |
Comment 4•11 years ago
|
||
Pushed after green tryserver build (https://tbpl.mozilla.org/?tree=Try&rev=1fa836a41f8d):
https://hg.mozilla.org/integration/fx-team/rev/8d1664e48b59
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•