Closed
Bug 929388
Opened 11 years ago
Closed 11 years ago
Incorporate a FxA Manager and FxA Client into the System app
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jedp, Assigned: ferjm)
References
Details
(Whiteboard: [qa+])
Attachments
(3 files, 18 obsolete files)
No description provided.
Assignee | ||
Updated•11 years ago
|
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → ferjmoreno
Comment 1•11 years ago
|
||
Assignee | ||
Comment 2•11 years ago
|
||
Updated•11 years ago
|
Whiteboard: [qa?]
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #820475 -
Attachment is obsolete: true
Assignee | ||
Updated•11 years ago
|
Summary: Incorporate a FXA Manager into the System app → Incorporate a FxA Manager and FxA Client into the System app
Assignee | ||
Comment 4•11 years ago
|
||
Now with web workers
Attachment #820987 -
Attachment is obsolete: true
Updated•11 years ago
|
Comment 5•11 years ago
|
||
Attachment #820428 -
Attachment is obsolete: true
Assignee | ||
Comment 6•11 years ago
|
||
Please, ignore the huge bundle.js file for now. It is there this way only for testing purposes.
Attachment #821041 -
Attachment is obsolete: true
Assignee | ||
Comment 7•11 years ago
|
||
Attachment #821654 -
Attachment is obsolete: true
Assignee | ||
Comment 8•11 years ago
|
||
Attachment #821557 -
Attachment is obsolete: true
Assignee | ||
Comment 9•11 years ago
|
||
Assignee | ||
Comment 10•11 years ago
|
||
Attachment #823269 -
Attachment is obsolete: true
Assignee | ||
Comment 11•11 years ago
|
||
Attachment #823920 -
Attachment is obsolete: true
Assignee | ||
Comment 12•11 years ago
|
||
Attachment #823302 -
Attachment is obsolete: true
Assignee | ||
Comment 13•11 years ago
|
||
Attachment #823279 -
Attachment is obsolete: true
Assignee | ||
Comment 14•11 years ago
|
||
Attachment #824021 -
Attachment is obsolete: true
Assignee | ||
Comment 15•11 years ago
|
||
Attachment #824012 -
Attachment is obsolete: true
Assignee | ||
Comment 16•11 years ago
|
||
Now the good one...
Attachment #824041 -
Attachment is obsolete: true
Updated•11 years ago
|
Whiteboard: [qa?] → [qa+]
Assignee | ||
Comment 17•11 years ago
|
||
Attachment #824046 -
Attachment is obsolete: true
Assignee | ||
Comment 18•11 years ago
|
||
Attachment #824022 -
Attachment is obsolete: true
Assignee | ||
Comment 19•11 years ago
|
||
I am pushing the changes to https://github.com/ferjm/gaia/tree/bug929388.fxamanager
Assignee | ||
Comment 20•11 years ago
|
||
Attachment #825960 -
Attachment is obsolete: true
Assignee | ||
Comment 21•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Attachment #824016 -
Attachment is obsolete: true
Assignee | ||
Updated•11 years ago
|
Attachment #830203 -
Attachment is obsolete: true
Comment 22•11 years ago
|
||
Comment on attachment 8339148 [details]
Gaia Pull Request
Hi Alive! This is the WIP patch that I showed you yesterday. Could you take a look? Thanks a lot!! 谢谢! :)
Attachment #8339148 -
Flags: feedback?(alive)
Comment 23•11 years ago
|
||
Haven't finished reading everything yet.
Observed architecture to me:
https://docs.google.com/drawings/d/1oztuLKf6ReiiFk97VmztuGWTp_hHe8NCAHq-5h-dmuE/edit?usp=sharing
Assignee | ||
Comment 24•11 years ago
|
||
Thanks Alive.
This is the higher level picture of the entire FxA system.
Comment 25•11 years ago
|
||
Comment on attachment 8339148 [details]
Gaia Pull Request
Overall it's fine but lots of coding style nits and unit tests seem unhappy.
I would suggest to decoupling module dependency by event publish/subscribe instead of calling directly. Lots of FxAccountXXXXX.yyyyyy make it hard to read. But it's up to you.
About the manifestURLs, I won't insist on checking the caller in this way but we have better to ask on the maillist: how to use IAC to identify the one who is connecting? Is this a proper way to go?
Attachment #8339148 -
Flags: feedback?(alive) → feedback+
Comment 26•11 years ago
|
||
Comment on attachment 8339148 [details]
Gaia Pull Request
Hi Alive! All your comments addressed, and now patches needed in Gecko are landed, So this feature is ready to be reviewed! r? Thanks! 谢谢!
Attachment #8339148 -
Flags: review?(alive)
Updated•11 years ago
|
Attachment #8339148 -
Flags: review?(ferjmoreno)
Assignee | ||
Comment 27•11 years ago
|
||
Comment on attachment 8339148 [details]
Gaia Pull Request
This looks great! :)
I added only some minor comments. I'd like to see a final version though.
Thanks!
Attachment #8339148 -
Flags: review?(ferjmoreno) → feedback+
Comment 28•11 years ago
|
||
Comment on attachment 8339148 [details]
Gaia Pull Request
I have no bandwidth to review it this week, but I think :ferjm's review is enough.
If there's a final version before I am OOO I'd try to give feedback. Thanks!
Attachment #8339148 -
Flags: review?(alive)
Comment 29•11 years ago
|
||
Comment on attachment 8339148 [details]
Gaia Pull Request
Francisco! Could you take a look? Thanks!
Attachment #8339148 -
Flags: review?(francisco.jordano)
Updated•11 years ago
|
Attachment #8339148 -
Flags: review?(ferjmoreno)
Assignee | ||
Comment 30•11 years ago
|
||
Comment on attachment 8339148 [details]
Gaia Pull Request
r=me with the comments addressed, please.
Also squash the commits and add r=ferjm, not r=fjimenez :P
Attachment #8339148 -
Flags: review?(ferjmoreno) → review+
Comment 31•11 years ago
|
||
Comment on attachment 8339148 [details]
Gaia Pull Request
r+ once fixed some minor comments regarding documentation and nits.
Also please apply the changes that Fernando requested, not all of them are applied despite that there are comments saying so, perhaps some files were not updated?
Amazing job from everyone involved. Incredible.
Thanks folks!
Attachment #8339148 -
Flags: review?(francisco.jordano) → review+
Comment 32•11 years ago
|
||
Hi Fernando,
I'm flagging you as needinfo cause of my comment here:
https://github.com/mozilla-b2g/gaia/pull/14101/files#diff-b32b94ec058b67e99347f7a66a394c87R107
I'm a bit concern about possible security leaks, if we leave in the system app access to a test application that won't be installed on the phone.
IMHO, we should remove it.
F.
Flags: needinfo?(ferjmoreno)
Assignee | ||
Comment 33•11 years ago
|
||
This is actually true! However, it is a shame that we can't have a test app or UI tests because of this. I would prefer to add an extra rule to also limit the connection to certified apps only instead of getting rid of the test app. What do you think?
Flags: needinfo?(ferjmoreno) → needinfo?(francisco.jordano)
Comment 34•11 years ago
|
||
Right, that sounds to me like the perfect solution.
Thanks Fernando!
Flags: needinfo?(francisco.jordano)
Assignee | ||
Comment 35•11 years ago
|
||
Great, thanks! I've just sent a PR with that change and a fix for the unit tests.
Comment 36•11 years ago
|
||
Travis Green, Feedback&R+, Merge this!
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•