Closed
Bug 929414
Opened 11 years ago
Closed 11 years ago
Fix small bug in MacroAssembler::extractTag
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
h4writer
:
review+
|
Details | Diff | Splinter Review |
extractTag with TypedOrValueRegister uses:
mov(ImmWord(ValueTypeFromMIRType(reg.type())), scratch);
But the JSValueType is a value between 0 and 7. What we want is MIRTypeToTag to get the tag (like 0xffffff8x on x86).
This improves the Clojurescript "[] (list 1 2 3)" test from 540 to 269 ms. Without this patch, SetPropertyIC's guardTypeSet always fails if the value is typed.
Attachment #820269 -
Flags: review?(hv1989)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 820269 [details] [diff] [review]
patch.patch
Review of attachment 820269 [details] [diff] [review]:
-----------------------------------------------------------------
Good catch!
Attachment #820269 -
Flags: review?(hv1989) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
|
||
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•