Closed Bug 929469 Opened 11 years ago Closed 7 years ago

Add reflow markers invalidation reason

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

Product:
DevTools
Component:
Performance Tools (Profiler/Timeline)
Platform:
x86
All
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: paul, Unassigned)

References

Details

(Keywords: perf, Whiteboard: [devtools-platform][c=devtools p= s= u=])

User Story

As a developer, I would like to find out why a layout has been invalidated when a reflow is triggered.
Since bug 926371, we can see when reflow are triggered. If a reflow is forced because a JS call (node.clientTop), we can show the JS stack. But if the layout has been invalidated because of some CSS reasons, the resulting reflow doesn't come with any interesting data.
Summary: Show why the layout as been invalidated → Show why the layout has been invalidated
Summary: Show why the layout has been invalidated → Show why layout has been invalidated
Blocks: perf-kanban
Component: Developer Tools → Developer Tools: User Stories
User Story: (updated)
Keywords: perf
Whiteboard: [c=devtools p= s= u=]
This is a thing BenWa has been working on (part of the profiler trace).
Paul, could anything like this be part of the new Perf Tools timeline view?
Flags: needinfo?(paul)
Yes. We should show if it's sync or async reflow. If it's a sync reflow, we should show the stack, if it's an async reflow, we should show why the layout has been invalidated.
Component: Developer Tools: User Stories → Developer Tools: Performance Tools (Profiler/Timeline)
Flags: needinfo?(paul)
All reflows with a stack are sync, correct? How can we get the async invalidation reason?
Summary: Show why layout has been invalidated → [marker] Include Async/CSS invalidation reason in Reflow markers
Similar to adding invalidation reason to style markers in bug 1131661
Summary: [marker] Include Async/CSS invalidation reason in Reflow markers → [marker] Reflow: invalidation reason
Whiteboard: [c=devtools p= s= u=] → [devtools-platform][c=devtools p= s= u=]
Triaging. Filter on LULUGUBRIOUSUS.
Priority: -- → P3
Triaging. Filter on ADRENOCORTICOTROPIC (yes).
Summary: [marker] Reflow: invalidation reason → Add reflow markers invalidation reason
I believe some of this information was stripped away due to recent stylo changes. I'm closing this for now.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.