Closed Bug 929643 Opened 11 years ago Closed 11 years ago

Change appropriate tests to fail-if for device/Hamachi manifest

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
Other
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: zcampbell, Assigned: zcampbell)

Details

Attachments

(1 file)

github pr
(deleted), text/x-github-pull-request
davehunt
: review+
rwood
: review+
Details
change xfailed tests to use fail-if = device != "desktop" or fail-if = device == "hamachi"
No longer depends on: 929636
I'm not sure the Hamachi will present itself as 'hamachi' but it might be another name. It's questionable whether we should use these other names or somehow map them to our codenames. See also bug 919574 for context.
Yes it looks like it's reported as "msm7627a". Not really concerned what the name is exactly (provided it's stable), more that we can run the maximum tests at any time on whichever b2g we're running against!
The issue is that the reported name may not be something we want to expose. Please see the bug referenced in comment 1.
Since we're getting this string from the device, any mapping that we build would have to include the offending string, so we wouldn't really be hiding it, just putting it in a different place.
Attached file github pr (deleted) —
Attachment #821683 - Flags: review?(florin.strugariu)
Attachment #821683 - Flags: review?(dave.hunt)
Comment on attachment 821683 [details] github pr @rwood, small change to default setting in endurance manifest
Attachment #821683 - Flags: review?(rwood)
Comment on attachment 821683 [details] github pr See comments in pull request.
Attachment #821683 - Flags: review?(dave.hunt) → review-
Attachment #821683 - Flags: review- → review?(dave.hunt)
Attachment #821683 - Flags: review?(dave.hunt) → review-
Attachment #821683 - Flags: review- → review?(dave.hunt)
Comment on attachment 821683 [details] github pr Thanks Zac
Attachment #821683 - Flags: review?(rwood) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee: nobody → zcampbell
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: