Closed
Bug 930165
Opened 11 years ago
Closed 11 years ago
[B2G][1.2][l10n][Settings]: "Fixed dialing numbers" in Call Settings is not translated across the locales
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(blocking-b2g:koi+, b2g-v1.2 fixed)
People
(Reporter: nkhristoforov, Assigned: soumyakanti.chakraborty)
Details
(Keywords: l12y, Whiteboard: [LocRun1.2],[good first bug])
Attachments
(2 files, 1 obsolete file)
Screenshot
In Call Settings, the "Fixed dialing numbers" option is not translated across the various languages.
Repro Steps:
1) Updated Buri to BuildID: 20131023004005
2) Choose any non-English language as the language during set-up.
3) Select Settings.
4) Select Call Settings under Wifi.
5) Verify "Fixed dialing numbers" is not translated.
Actual:
"Fixed dialing numbers" is not translated to the selected language.
Expected:
"Fixed dialing numbers" is translated to the selected language.
Environmental Variables:
Device: Buri v 1.2 COM RIL
BuildID: 20131023004005
Gaia: 1ca623e7a79a9653b54a45ef7f8bb03b8d7100fc
Gecko: bb33e2fe109c
Version: 26.0a2
Firmware Version: 20131015
Repro frequency: 100%
See attached: Screenshot
|
||
Comment 1•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/elements/call.html#L58 is
<a data-href="#call-fdnSettings" data-l10n-id="fdn">Fixed dialing numbers</a>
data-l10n-id should fdnSettings to use the localized string.
Whiteboard: LocRun1.2 → [LocRun1.2][good first bug]
|
Assignee | |
Comment 2•11 years ago
|
||
The bug is similar to Bug 931640, so I will take it up and please assign it to me.
|
|
Assignee | |
Comment 3•11 years ago
|
||
Attachment #824389 -
Flags: review?(archaeopteryx)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Please consider the new pull request
Attachment #824389 -
Attachment is obsolete: true
Attachment #824389 -
Flags: review?(archaeopteryx)
Attachment #824516 -
Flags: review?(archaeopteryx)
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 824516 [details]
Bug 930165 patch
I am not a module peer, so I can't review that. Redirecting to kaze for review.
Attachment #824516 -
Flags: review?(archaeopteryx) → review?(kaze)
|
|
||
Updated•11 years ago
|
Assignee: nobody → soumyakanti.chakraborty
Status: NEW → ASSIGNED
|
||
Comment 6•11 years ago
|
||
Comment on attachment 824516 [details]
Bug 930165 patch
Good catch, thanks!
Attachment #824516 -
Flags: review?(kaze) → review+
|
|
||
Comment 7•11 years ago
|
||
Merged on master: https://github.com/mozilla-b2g/gaia/commit/aa6565c30133b7e03e1f49161c489918653e2d3e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
||
Updated•11 years ago
|
blocking-b2g: --- → koi?
|
||
Updated•11 years ago
|
blocking-b2g: koi? → koi+
|
||
Comment 8•11 years ago
|
||
Uplifted aa6565c30133b7e03e1f49161c489918653e2d3e to:
v1.2: c92c6fdb2e8af9d0d2a3f7c0c93877e394fd487a
status-b2g-v1.2:
--- → fixed
|
||
Comment 9•11 years ago
|
||
Still repros on the Croatian, Polish and Serbian (Latin and Cyrillic) languages on Buri 1.2 commercial RIL. The other languages show the Fixed Dialing Numbers text in their language.
Build ID: 20131108004004
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/a886c641a306
Gaia: 4cf40fb30c7b8380ea83ed0d4efe043b8b81737f
Platform Version: 26.0
RIL Version: 01.02.00.019.102
No longer blocks: 928174
Whiteboard: [LocRun1.2][good first bug] → [LocRun1.2],[good first bug]
You need to log in
before you can comment on or make changes to this bug.
Description
•