Closed Bug 930380 Opened 11 years ago Closed 11 years ago

Make sure *SOURCES only point to existing files

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla27

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(3 files, 5 obsolete files)

Script used for checking
(deleted), text/x-python
Details
Make sure *SOURCES only point to existing files
(deleted), patch
gps
: review+
Details | Diff | Splinter Review
Fix host source rules when path contains a directory
(deleted), patch
gps
: review+
Details | Diff | Splinter Review
Like bug 912099 and bug 912438, but for other source variables.
Attached file Script used for checking (obsolete) (deleted) —
I used this script to check variables. It doesn't handle list comprehension or assigning from another variable, but those are more or less handled by a try build. I ignored everything Qt (moc_* and files under widget/qt/faststartupqt) which are already broken anyways, and toolkit/crashreporter/client/moz.build, for which i filed bug 930379 (it's solaris-only)
Attachment #821476 - Attachment mime type: text/x-python → text/plain
Attached patch Make sure *SOURCES only point to existing files (obsolete) (deleted) — — Splinter Review
https://tbpl.mozilla.org/?tree=Try&rev=c28cfe92358c
Assignee: nobody → mh+mozilla
Attachment #821478 - Flags: review?(gps)
Attachment #821478 - Attachment is patch: true
Attached file Script used for checking (deleted) —
With a fixup to check lists of 1 element (the script is derived from the script i used for reordering, which didn't have to care about those)
Attachment #821476 - Attachment is obsolete: true
Refreshed. That requires another patch I'll attach shortly.
Attachment #821478 - Attachment is obsolete: true
Attachment #821478 - Flags: review?(gps)
Attachment #821484 - Flags: review?(gps)
Turns out pymake screwed up with the last iteration. I would normally file a bug on pymake, but at this point of mozmake progress, i think i don't care about fixing pymake.
Attachment #821509 - Flags: review?(gps)
Attachment #821485 - Attachment is obsolete: true
Attachment #821485 - Flags: review?(gps)
Blocks: 929905
A version that should actually work on windows: https://tbpl.mozilla.org/?tree=Try&rev=4a2a74f448a5
Attachment #821523 - Flags: review?(gps)
Attachment #821509 - Attachment is obsolete: true
Attachment #821509 - Flags: review?(gps)
This is getting embarassing, but this time, I think it's the good one: https://tbpl.mozilla.org/?tree=Try&rev=6a04b8406e28
Attachment #821564 - Flags: review?(gps)
Attachment #821523 - Attachment is obsolete: true
Attachment #821523 - Flags: review?(gps)
Attachment #821484 - Flags: review?(gps) → review+
Attachment #821564 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/748e46ad4ab3 https://hg.mozilla.org/mozilla-central/rev/345cb5e077b1
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Depends on: 932280
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: