Closed Bug 930546 Opened 11 years ago Closed 11 years ago

[Media] Replace Gradient Background with Solid Colour

Categories

(Firefox OS Graveyard :: Gaia, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: padamczyk, Assigned: pivanov)

References

Details

(Whiteboard: ux-tracking, visual design, jian)

Attachments

(5 files, 3 obsolete files)

bug_background.png
(deleted), image/png
Details
Exampe of Gallery
(deleted), image/png
Details
Example of Video
(deleted), image/png
Details
After patch screenshot
(deleted), image/png
padamczyk
: feedback+
Details
patch for Gaia/master
(deleted), text/x-github-pull-request
sjochimek
: review+
Details
Attached image bug_background.png (deleted) —
In the media apps (gallery, music and videos) there is a gradient background, please remove it and replace it with a solid colour fill #0E1214
Attached image Exampe of Gallery (deleted) —
Attached image Example of Video (deleted) —
Attached image after_patch_screenshot.png (obsolete) (deleted) —
Hey Patryk, I Replace Gradient Background with Solid Colour (#222d33) I also remove the shadow ... do I need to change the height of the buttons because now the header is with 5rem height and the buttons is with 4.9rem height? or this will be changed in another bug ... maybe with restyle the headers [BB]?
Flags: needinfo?(padamczyk)
Hey Pavel, can you post a screenshot of each media screen not just the headers? Also yes the button should be 5rem now (this change should be part of the restyle BB bug)
Flags: needinfo?(padamczyk) → needinfo?(pivanov)
Priority: -- → P1
Attached image After patch screenshot (obsolete) (deleted) —
Attachment #824650 - Flags: feedback?(padamczyk)
Flags: needinfo?(pivanov)
Pavel I think there is a misunderstanding what this bug is all about... each media app has a background, in most cases its a gradient (https://bugzilla.mozilla.org/attachment.cgi?id=821696). We want this gradient ripped out and replaced with a solid colour fill #0E1214. Media player background should be black #000000.
Flags: needinfo?(pivanov)
Attachment #824650 - Flags: feedback?(padamczyk) → feedback-
Attachment #822310 - Attachment is obsolete: true
Attachment #824650 - Attachment is obsolete: true
Attached image After patch screenshot (obsolete) (deleted) —
Hey Patryk, sorry for the mistake ... I think now I used the correct color
Attachment #825143 - Flags: feedback?(padamczyk)
Flags: needinfo?(pivanov)
Comment on attachment 825143 [details] After patch screenshot I meant the background of the APP not the Header.
Attachment #825143 - Flags: feedback?(padamczyk) → feedback-
Attachment #825143 - Attachment is obsolete: true
Attached image After patch screenshot (deleted) —
Hey Patryk, I change the app background collor not the header background color
Attachment #826341 - Flags: feedback?(padamczyk)
Comment on attachment 826341 [details] After patch screenshot Looks good now.
Attachment #826341 - Flags: feedback?(padamczyk) → feedback+
Attached file patch for Gaia/master (deleted) —
Attachment #826919 - Flags: review?(sjochimek)
Comment on attachment 826919 [details] patch for Gaia/master Pavel: Comments on github. [FMB]
Attachment #826919 - Flags: review?(sjochimek)
Attachment #826919 - Flags: review?(sjochimek)
Comment on attachment 826919 [details] patch for Gaia/master Landed in master: https://github.com/mozilla-b2g/gaia/commit/40c8322d315538fdbb15b9cd470d90aaa7a55d5a
Attachment #826919 - Flags: review?(sjochimek) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: