Closed Bug 930583 Opened 11 years ago Closed 11 years ago

Stop #including nsEventStateManager in nsWindowRoot.h and nsDocument.h

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla27

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Stop #including nsEventStateManager in nsWindowRoot.h and nsDocument.h
(deleted), patch
smaug
: review+
Details | Diff | Splinter Review
No description provided.
Attachment #821749 - Flags: review?(bugs)
Assignee: nobody → ehsan
Comment on attachment 821749 [details] [diff] [review] Stop #including nsEventStateManager in nsWindowRoot.h and nsDocument.h Really odd to require to include various JS headers.
Attachment #821749 - Flags: review?(bugs) → review+
(In reply to Olli Pettay [:smaug] from comment #3) > Comment on attachment 821749 [details] [diff] [review] > Stop #including nsEventStateManager in nsWindowRoot.h and nsDocument.h > > Really odd to require to include various JS headers. I think those headers used to be indirectly included through nsEventStateManager.h. This kind of thing is pretty common in includehell patches. :-)
https://hg.mozilla.org/mozilla-central/rev/15cf10638afe
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
I got errors in HTMLAllCollection.obj and nsBindingManager.obj when linking xu.dll HTMLAllCollection.obj : error LNK2019: "public: class JSObject * __cdecl nsWrapperCache::GetWrapper(void)const " (?GetWrapper@nsWrapperCache@@QEBAPEAVJSObject@@XZ) nsBindingManager.obj : error LNK2001: "public: class JSObject * __cdecl nsWrapperCache::GetWrapper(void)const " (?GetWrapper@nsWrapperCache@@ QEBAPEAVJSObject@@XZ)
(In reply to zhoubcfan from comment #7) > I got errors in HTMLAllCollection.obj and nsBindingManager.obj when linking > xu.dll > > HTMLAllCollection.obj : error LNK2019: "public: class JSObject * __cdecl > nsWrapperCache::GetWrapper(void)const " > (?GetWrapper@nsWrapperCache@@QEBAPEAVJSObject@@XZ) > > nsBindingManager.obj : error LNK2001: "public: class JSObject > * __cdecl nsWrapperCache::GetWrapper(void)const " > (?GetWrapper@nsWrapperCache@@ > QEBAPEAVJSObject@@XZ) I get the same error using GCC 4.5.1.
Depends on: 931427
I filed Bug 931427 on this issue.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: