Closed
Bug 930677
Opened 11 years ago
Closed 9 years ago
Mark fromMarkedLocation as needing approval from the JS team
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: evilpie, Unassigned)
References
Details
Unless of course you are bz or other DOM peer. We should add some very scary comment, like "THIS FUNCTION ABSOLUTELY REQUIRES APPROVAL FROM A KNOWLEDGEABLE JAVASCRIPT OR DOM PEER". I noticed somebody using it, because it probably just made stuff work. That is pretty bad. We might also want to look at some technical solution, I guess our current rooting analysis wouldn't notice it?
Comment 1•11 years ago
|
||
The static rooting analysis will ignore this function entirely, but it would be easy enough to extend the analysis with a whitelist (which could work by pattern matching) for valid arguments to fromMarkedLocation.
Comment 2•9 years ago
|
||
We seem to have enough institutional knowledge at this point that nobody is trying to use it as a simple type adapter anymore.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•