Closed
Bug 930876
Opened 11 years ago
Closed 11 years ago
Speed up per-tab profiling of JS by skipping the expensive string hashing.
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file)
|
(deleted),
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
The string hashing done in JS memory profiling is expensive and not used by the
per-tab measurements.
|
Assignee | |
Comment 1•11 years ago
|
||
Time taken to profile JS memory:
before after
gmail.com 21ms 7ms
techcrunch.com 19ms 9ms
With the patch applied, |perf| tells me that there is nothing beyond that worth
optimizing -- most of the time is spent in malloc_usable_size().
Attachment #822151 -
Flags: review?(till)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 822151 [details] [diff] [review]
Speed up per-tab profiling of JS by skipping the expensive string hashing.
Review of attachment 822151 [details] [diff] [review]:
-----------------------------------------------------------------
nice!
Attachment #822151 -
Flags: review?(till) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•