Closed Bug 930901 Opened 11 years ago Closed 11 years ago

Clean up and modularize SessionStore code a little more

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 28

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

Attachments

(3 files, 3 obsolete files)

Move TabState and TabAttributes to their own JSMs, v2
(deleted), patch
billm
: review+
Details | Diff | Splinter Review
Introduce Utils.jsm, v2
(deleted), patch
billm
: review+
Details | Diff | Splinter Review
Rename _SessionFile to SessionFile, v2
(deleted), patch
billm
: review+
Details | Diff | Splinter Review
Based off of bug 930202 and bug 919835 we can do some cleanup and move TabState as well as TabAttributes to their own JSMs.
Attachment #822172 - Flags: review?(wmccloskey)
Small addition.
Attachment #822172 - Attachment is obsolete: true
Attachment #822172 - Flags: review?(wmccloskey)
Attachment #822189 - Flags: review?(wmccloskey)
Attached patch Introduce Utils.jsm (obsolete) (deleted) — — Splinter Review
This patch introduces a Utils.jsm that contains makeURI() and hasRootDomain(). We will need the latter for upcoming work.
Attachment #822199 - Flags: review?(wmccloskey)
Summary: Move TabState and TabAttributes to their own JSMs → Clean up and modularize SessionStore code a little more
Attached patch Introduce Utils.jsm, v2 (deleted) — — Splinter Review
Oops, little fix.
Attachment #822199 - Attachment is obsolete: true
Attachment #822199 - Flags: review?(wmccloskey)
Attachment #822209 - Flags: review?(wmccloskey)
Attached patch Rename _SessionFile to SessionFile (obsolete) (deleted) — — Splinter Review
Ok, while I'm at it... It always bugged me that we called it _SessionFile. Let's rename that to SessionFile (remove the underscore) so that it fits nicely with all our other modules.
Attachment #822211 - Flags: review?(wmccloskey)
That should be it. All those patches don't change how stuff works, they just move code around.
Sorry, sed fixed a couple of line endings that I didn't indent to include in the patch.
Attachment #822211 - Attachment is obsolete: true
Attachment #822211 - Flags: review?(wmccloskey)
Attachment #822217 - Flags: review?(wmccloskey)
Blocks: 930967
Comment on attachment 822189 [details] [diff] [review] Move TabState and TabAttributes to their own JSMs, v2 Review of attachment 822189 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for doing this. I'm going to try to land bug 919835 after the merge to aurora.
Attachment #822189 - Flags: review?(wmccloskey) → review+
Attachment #822217 - Flags: review?(wmccloskey) → review+
Attachment #822209 - Flags: review?(wmccloskey) → review+
Depends on: 936911
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: