Closed Bug 93111 Opened 23 years ago Closed 23 years ago

[EVENTTARG]Incorrect target for multi-row cells

Categories

(Core :: DOM: Events, defect)

x86
All
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla1.0

People

(Reporter: robert, Assigned: joki)

References

Details

(Keywords: testcase, topembed+, Whiteboard: [DIGBug][eapp][adt1])

Attachments

(2 files)

If a cell spans multiple rows, the target for events generated in the cell is sometimes the TR and not the TD. I've attached a test case for this. If you click in the upper half of the red cell the target is the TD, but if you click in the bottom half the target is the TR.
seeing this on linux build 2001-07-30-06 as well. Nice testcase!
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: testcase
OS: Windows 2000 → All
Whiteboard: [DIGBug]
Target Milestone: --- → mozilla1.0
Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 (you can query for this string to delete spam or retrieve the list of bugs I've moved)
Target Milestone: mozilla1.0 → mozilla1.0.1
nominating for nsbeta1
Keywords: nsbeta1
Whiteboard: [DIGBug] → [DIGBug][eapp]
Major corporations depend on eapp bugs, and need them to be fixed before they can recommend Mozilla-based products to their customers. Adding nsbeta1+ keyword and making sure the bugs get re-evaluated if they are targeted beyond 1.0.
Keywords: nsbeta1nsbeta1+
Target Milestone: mozilla1.0.1 → ---
eapp was incorrectly used to change this to nsbeta1+. Resetting to nsbeta1 to nominate. This is an important issue and deserves to be nsbeta1+ by the ADT.
Keywords: nsbeta1+nsbeta1
Keywords: topembed
Target Milestone: --- → mozilla1.0
*** Bug 95552 has been marked as a duplicate of this bug. ***
Summary: Incorrect target for multi-row cells → [EVENTTARG]Incorrect target for multi-row cells
Attached patch Proposed patch (deleted) — Splinter Review
Proposed patch. The patch makes nsTableRowFrame, nsTableRowGroupFrame, nsTableColFrame, and nsTableColGroupFrame invalid targets for events. This fixes the bug by keeping the nsTableRowFrame from stealing the events on rowspans. It also means that events over table areas without any cells fall through to the table element. This makes us more compatible with IE which does the same thing so this should also be a good change.
Comment on attachment 79006 [details] [diff] [review] Proposed patch sr=jst
Attachment #79006 - Flags: superreview+
Attachment #79006 - Flags: review+
Comment on attachment 79006 [details] [diff] [review] Proposed patch r=dbaron
Nominating for adt1.0.0. This is an eapp, DIGBug, and topembed+. A lot of people want to see it get fixed. The patch is reasonably low risk.
Keywords: adt1.0.0
If you haven't already, could you check this into the trunk and update the bug when it's been tested.
Additionally, if you could work with Saari to make sure there is an ADT impact (ADT1-3)marking in the bug, that would be great too!
Keywords: approval
Fix checked into trunk. Marking bug fixed. Still looking for 1.0 branch approval.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Marking [adt1] as it is a import bug for DIG
Whiteboard: [DIGBug][eapp] → [DIGBug][eapp][adt1]
Comment on attachment 79006 [details] [diff] [review] Proposed patch a=asa (on behalf of drivers) for checkin to the 1.0 branch
Attachment #79006 - Flags: approval+
amar, please verify this bug is fixed on the trunk. The adt needs to know it's tested before the fix is checked into the branch. thanks!
verifying on build 2002-04-15-03-trunk win 2000 build 2002-04-17-03-trunk OSX build 2002-04-17-07-trunk Linux RedHat
Whiteboard: [DIGBug][eapp][adt1] → [DIGBug][eapp][adt1][VERIFIED_ON_TRUNK]
In other words, marking verified. Once fixed on the branch, change the adt keyword to fixed1.0.0, and once verified on the branch, add verified1.0.0 keyword.
Status: RESOLVED → VERIFIED
Whiteboard: [DIGBug][eapp][adt1][VERIFIED_ON_TRUNK] → [DIGBug][eapp][adt1]
adding adt1.0.0+ on behalf of the adt. Please check this into the branch as soon as possible and add the fixed1.0.0 keyword.
Keywords: adt1.0.0adt1.0.0+
Fixed on branch.
Keywords: fixed1.0.0
Verifying on 07/17 branch on windows 98 and Linux RedHat
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: