Closed
Bug 931201
(Nederlands-WordPrediction)
Opened 11 years ago
Closed 11 years ago
[B2G][1.2][l10n][Keyboard] Nederlands: Autocorrection does not work Nederlands Dutch language
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(blocking-b2g:koi+, b2g-v1.2 fixed)
People
(Reporter: KTucker, Assigned: rudyl)
References
Details
(Whiteboard: LocRun1.2)
Attachments
(2 files, 1 obsolete file)
Description:
The user cannot add a keyboard in the "Nederlands Dutch" language.
Repro Steps:
1) Updated Buri to Build ID: 20131025004000
2) Tap on "Settings".
3) Tap on "Keyboards".
4) Tap on "Selected keyboards".
5) Tap on "Add more keyboards".
6) Scroll through the languages available.
Actual:
The "Nederlands/Dutch" language is missing in the available keyboards.
Expected:
The "Nederlands/Dutch" language is an available keyboard.
Environmental Variables
Device: Buri v 1.3.0 COM RIL
Build ID: 20131025004000
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/5eabd267ef04
Gaia: 606517ceafe0950c2b89822d5f13353743334f2c
Platform Version: 26.0a2
RIL Version: 01.02.00.019.082
Notes:
Repro frequency: 100%
See attached: screenshot
Comment 1•11 years ago
|
||
As an FYI, Dutch keyboard would be the same as English US, just with Dutch dictionary.
Comment 2•11 years ago
|
||
Ton: can you please check that Dutch dictionary is OK and that no further action concerning Dutch Keyboard is required?
Flags: needinfo?(tonnes.mb)
Comment 3•11 years ago
|
||
(In reply to delphine from comment #2)
> Ton: can you please check that Dutch dictionary is OK and that no further
> action concerning Dutch Keyboard is required?
this is right.
Comment 4•11 years ago
|
||
Thanks Tim. How about the auto-completion in Dutch, does it seem ok with you?
(ni? again, sorry about that...)
Flags: needinfo?(bugzilla)
Comment 5•11 years ago
|
||
build 20131030224023
Auto correction works now as aspected, and the keyboard is ok. But i would aspect to have the possibility to select a keyboard 'dutch' even it is the same as the english one. Not every user knows that.
Flags: needinfo?(bugzilla)
Comment 6•11 years ago
|
||
I wouldn't know how to check the Dutch dictionary and where it resides. Also, Auto completion does not seem to work for Dutch, only English suggestions appear (in latest builds).
I'm not sure whether or not it's a good idea to include a Dutch keyboard, as it simply does not exist AFAICT. Dutch people use English keyboard layouts (and tend to know that very well), only the input language may differ (but nobody uses it), resulting in other characters being displayed than the ones used on the en-US layout, which is most often switched to by mistake.
Flags: needinfo?(tonnes.mb)
Comment 7•11 years ago
|
||
Ton, wich build do you use. autocorrection does work for me i the latest build?
Comment 8•11 years ago
|
||
sorry you say I your commend that you had the latest build, what is the build number. I checked the autocorrection see #5 and for me is working.
Comment 9•11 years ago
|
||
sorry for the bugspam but it look like Ton is right. i did some more testing and now i think i had some false positives yesterday when i was testing.
autocorrection does not work!
Comment 10•11 years ago
|
||
Ok flagging David about this and asking for koi+
blocking-b2g: --- → koi?
Flags: needinfo?(dflanagan)
Summary: [B2G][1.2][l10n][Keyboard] Nederlands: The user cannot add a keyboard in the Nederlands Dutch language → [B2G][1.2][l10n][Keyboard] Nederlands: Autocorrection does not work Nederlands Dutch language
Comment 11•11 years ago
|
||
We have nl.dict in the tree, we simply need to copy the layout file.
blocking-b2g: koi? → koi+
Flags: needinfo?(dflanagan)
Whiteboard: LocRun1.2 → LocRun1.2, [mentor=timdream][mentor=rudyl][mentor=djf]
Comment 12•11 years ago
|
||
https://en.wikipedia.org/wiki/QWERTY#Dutch_.28Netherlands.29
Need a few extra symbols like the Euro sign.
Comment 15•11 years ago
|
||
Comment on attachment 831379 [details]
mozilla-b2g:master PR#13655
I simply rip the English keyboard and changed it's id and naming.
Need a native speaker to give some feedback too.
Attachment #831379 -
Flags: review?(rlu)
Attachment #831379 -
Flags: feedback?(janjongboom)
Assignee | ||
Comment 16•11 years ago
|
||
Hi Tim,
I am going to steal this bug from you, since I remember we already did NL on v1-train, but not landed it to master for some reason, and I'll handle this.
Sorry that did not take this earlier.
Assignee: timdream → rlu
Status: NEW → ASSIGNED
Assignee | ||
Comment 17•11 years ago
|
||
Hi Jan,
This is a simple patch to take Dutch keyboard layout from v1.1.
Besides, also clean up some entried in shared/resources/keyboard_layouts.json
Thanks.
Attachment #831379 -
Attachment is obsolete: true
Attachment #831379 -
Flags: review?(rlu)
Attachment #831379 -
Flags: feedback?(janjongboom)
Attachment #831448 -
Flags: review?(janjongboom)
Assignee | ||
Updated•11 years ago
|
Whiteboard: LocRun1.2, [mentor=timdream][mentor=rudyl][mentor=djf] → LocRun1.2
Comment 18•11 years ago
|
||
Comment on attachment 831448 [details]
Patch V1 - pull request 13658
Hi, i am not so good in coding but if i look to this patch i see a code for '$' but not for €. I think we need this for all euro countries.
Assignee | ||
Comment 19•11 years ago
|
||
(In reply to Tim Maks van den Broek [:mad_maks] from comment #18)
> Comment on attachment 831448 [details]
> Patch V1 - pull request 13658
>
> Hi, i am not so good in coding but if i look to this patch i see a code for
> '$' but not for €. I think we need this for all euro countries.
Thanks for the feedback, we show '$' as an alternative character for 's', and will show '€' and other currency symbols in the symbol panel (after you press [?123] button).
Comment 20•11 years ago
|
||
(In reply to Rudy Lu [:rudyl] from comment #19)
> (In reply to Tim Maks van den Broek [:mad_maks] from comment #18)
> > Comment on attachment 831448 [details]
> > Patch V1 - pull request 13658
> >
> > Hi, i am not so good in coding but if i look to this patch i see a code for
> > '$' but not for €. I think we need this for all euro countries.
>
> Thanks for the feedback, we show '$' as an alternative character for 's',
> and will show '€' and other currency symbols in the symbol panel (after you
> press [?123] button).
I think we should show the Euro sign in the alt menu for the key 'e' (we do that on English keyboard so there is really no reason not to do so on the Dutch keyboard.)
Status: ASSIGNED → NEW
Updated•11 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 21•11 years ago
|
||
Comment on attachment 831448 [details]
Patch V1 - pull request 13658
Hi all,
Thanks for your feedback.
Patch updated to add '€' as an alternative char of 'e'.
Tim, could you help review this?
Thank you.
Attachment #831448 -
Flags: review?(janjongboom) → review?(timdream)
Comment 22•11 years ago
|
||
Comment on attachment 831448 [details]
Patch V1 - pull request 13658
Thanks!
Attachment #831448 -
Flags: review?(timdream) → review+
Comment 23•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 24•11 years ago
|
||
Uplifted ea2711787ece8d6f4d22c310d3e8a8080a5ee090 to:
v1.2: 5be4c9a035b454455bcce1f1ccaeb649397ae4be
Comment 25•11 years ago
|
||
geeksphone keon OTA update to build 20131119224416, git info: 2013-11-19 20:23:03
i still don't have a dutch keyboard. is there someting wrong on the mozilla site or geeksphone?
there are a lot new keyboard added but no dutch one.
Assignee | ||
Comment 26•11 years ago
|
||
Hi,
After Bug 884752 has landed, you would need to specify which keyboard layout to be included in the build,
e.g. add this env. variable when building Gaia would get you Dutch layout,
> GAIA_KEYBOARD_LAYOUTS=en,pt-BR,es,de,fr,pl,nl
If it is geeksphone, it depends on their build script to include this flag.
So, you might want to try to build your own Gaia.
Comment 27•11 years ago
|
||
Thanks rudy, i post a question about it on there forum
Comment 28•11 years ago
|
||
Added in GP images. Please if any user ask for a layout in GP images sent them to our forums. Thanks
Comment 29•11 years ago
|
||
that is a fast response. thanks. I will confirm it here after the build tomorrow.
Comment 30•11 years ago
|
||
I still don’t see the point of adding a Dutch keyboard layout if it doesn’t exist - see comment 6. Or rather, they tend to exist, but are very rare, and certainly not the same as (a copy of) the widely used en-US keyboard. IMO we’d be messing with the definitions here and confuse users.
Comment 31•11 years ago
|
||
I can confirm that the auto suggestion works as aspected, thanks. I found a general bug with it and will file this as a sepperate bug. ( If you select a sugestion that is shorthend like 'afstan...iening' it will use the word with the dots in de message).
Comment 32•11 years ago
|
||
Verified that auto correct works in Dutch/Nederlands
Environmental Variables:
Device: Buri v1.2 COM RIL
BuildID: 20131202004001
Gaia: 075e60c878b0eca68fba9e00bc85cb6eac03578a
Gecko: 14868788d50e
Version: 26.0
Firmware Version: V1.2_20131115
Status: RESOLVED → VERIFIED
Updated•10 years ago
|
Blocks: WordPrediction
Updated•9 years ago
|
Alias: Nederlands-WordPrediction
You need to log in
before you can comment on or make changes to this bug.
Description
•