Szu-Yu Chen [:aknow] (inactive) Assignee
	Description • 11 years ago

      No description provided.

	Szu-Yu Chen [:aknow] (inactive) Assignee
	Comment 2 • 11 years ago

1. dsds outgoing call test
2. startDSDSTest() macro in head.js

	Hsin-Yi Tsai (she/her) [:hsinyi]
	Comment 3 • 11 years ago

Comment on attachment 827880 [details] [diff] [review]
Add dsds outgoing call marionette test

Review of attachment 827880 [details] [diff] [review]:
-----------------------------------------------------------------

General comment: Please don't forget manifest.in

::: dom/telephony/test/marionette/head.js
@@ +160,5 @@
> +
> +  if (numRIL > 1) {
> +    startTest(test);
> +  } else {
> +    log('Not a DSDS environment. Test is skipped.');

nit: use double quotation mark.

::: dom/telephony/test/marionette/test_dsds_outgoing.js
@@ +130,5 @@
> +
> +  return deferred.promise;
> +}
> +
> +function makeCallForServiceId(number, serviceId) {

I'd rename it testOutgoingCallForServiceId.

And I'd like to see 'testIncomingCallForServiceId' too. :)

@@ +139,5 @@
> +    .then(() => dial(number, serviceId))
> +    .then(call => { outCall = call; })
> +    .then(() => {
> +      is(outCall.serviceId, serviceId);
> +      return checkAll(outCall, [outCall], [outInfo.ringing]);

We don't need 'return', i.e. |checkAll(outCall, [outCall], [outInfo.ringing]);| is fine.

	Szu-Yu Chen [:aknow] (inactive) Assignee
	Comment 4 • 11 years ago

> @@ +139,5 @@
> > +    .then(() => dial(number, serviceId))
> > +    .then(call => { outCall = call; })
> > +    .then(() => {
> > +      is(outCall.serviceId, serviceId);
> > +      return checkAll(outCall, [outCall], [outInfo.ringing]);
> 
> We don't need 'return', i.e. |checkAll(outCall, [outCall],
> [outInfo.ringing]);| is fine.

I think 'return' is needed.

.then(() => {
  is(outCall.serviceId, serviceId);
  return checkAll(outCall, [outCall], [outInfo.ringing]);
})

checkAll() return a promise. We should return it. Otherwise, the next .then part will be execute immediately.

	Szu-Yu Chen [:aknow] (inactive) Assignee
	Comment 5 • 11 years ago

1. Add incoming call test.
2. I would like to rename the filename to "test_dsds_normal_call" (also in manifest). This part is not included in the patch to avoid the difficulty of diff view after renaming.

	Hsin-Yi Tsai (she/her) [:hsinyi]
	Comment 7 • 11 years ago

Comment on attachment 8342195 [details] [diff] [review]
#2 multisim test (Add dsds outgoing call marionette test)

Review of attachment 8342195 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

	Hsin-Yi Tsai (she/her) [:hsinyi]
	Comment 8 • 11 years ago

Comment on attachment 8342198 [details] [diff] [review]
file rename

Review of attachment 8342198 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Please squish the two patches into one for landing, thanks.

	Szu-Yu Chen [:aknow] (inactive) Assignee
	Comment 10 • 11 years ago

https://tbpl.mozilla.org/?tree=Try&rev=d4c47f6b0eb2

	Ryan VanderMeulen [:RyanVM]
	Comment 11 • 11 years ago

https://hg.mozilla.org/integration/b2g-inbound/rev/08d07ae47342

	Ryan VanderMeulen [:RyanVM]
	Comment 12 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/08d07ae47342