Closed
Bug 932140
Opened 11 years ago
Closed 11 years ago
[B2G][1.2][l10n][Settings] Romanian: "Fixed dialing numbers" is truncated (header and setting)
Categories
(Mozilla Localizations :: ro / Romanian, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: tchevalier, Unassigned)
References
Details
(Keywords: l12y, Whiteboard: LocRun1.2)
Attachments
(3 files)
(deleted),
image/jpeg
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
image/png
|
Details |
In Romanian, there are truncations in the FDN setting.
The header displays "Numere de apelare fi…" while the setting displays "Numere de apelare …"
STR:
1. Open Settings
2. Go to "Call settings"
3. Go to "Fixed dialing numbers"
Actual Result:
The header is truncated.
The string at the left of the switch is truncated.
Expected result:
Both strings fits into the screen
Device: Keon 1.2
BuildID: 20131026225502
Comment 1•11 years ago
|
||
I don't know how can I shorten this. I think we need a general solution from UX team, because the font is too big and some elements from the page can be moved and/or decreased slightly. :) The main problem is that many strings are nearly fitted into the screen, but as well as in this case, the header should be "Numere de apelare fixă", so just 2 words: "...xă".
Best Regards,
Cristian Silaghi
Reporter | ||
Comment 2•11 years ago
|
||
Hi Cristian,
I made a little patch (it's more a hack than a real solution, thought) do you think it would be acceptable for Romanian?
The patch consists in replacing current 'classic' spaces with U+202F character (NARROW NO-BREAK SPACE), reducing the space between words to make the title fit.
For the second truncation, UX feedback is indeed needed, especially because there is already a truncation in en-US.
@fxos-ux, Is there an opened bug for the en-US truncation in FDN setting?
Attachment #824095 -
Flags: feedback?(cristian.silaghi)
Flags: needinfo?(firefoxos-ux-bugzilla)
Reporter | ||
Comment 3•11 years ago
|
||
Comment 4•11 years ago
|
||
After patch, header are OK but FDN setting are still truncated. However, perhaps real solution are reducing font dimension, e.g. 7px instead of 10 px.
Comment 5•11 years ago
|
||
Hi Théo,
Yes, with your patch now it is acceptable. :) What about the other string?
Best Regards,
Cristian Silaghi
Reporter | ||
Comment 6•11 years ago
|
||
For the setting, I think we should wait for UX point of view, to see if they have an idea and/or to see if the en-US truncation is being tracked somewhere. If so, we would just have to wait for it to be resolved.
My personal point of view is that since the header is now fully readable for the user, the setting name being truncated becomes an issue less important: they understand that the setting is the same sentence as in the title. But again, let's UX answer.
Comment 7•11 years ago
|
||
Thanks, Theo. I am flagging Eric to advise on this one. Eric does have a larger solution for this sort of thing, but it may not be able to make it into the BB (for headers) immediately, so he'll be able to say if we need an ad hoc solution for this one or not. Cheers!
Flags: needinfo?(firefoxos-ux-bugzilla) → needinfo?(epang)
Comment 8•11 years ago
|
||
Hi Theo, I'm marking this as dependent on bug 908309. It's a bug that I opened a while back that proposes a second line within setting list items when truncation exist. Thanks!
Depends on: 908309
Flags: needinfo?(epang)
Comment 9•11 years ago
|
||
Hi Théo,
Why I get on the email "[Bugzilla] Your Outstanding Requests (1 feedback)". It's annoying.
I already asked here. Your hack is great. So I hope this change is merged.
Best Regards,
Cristian Silaghi
Comment 10•11 years ago
|
||
answered*, not asked.
Sorry about this
Reporter | ||
Comment 11•11 years ago
|
||
(In reply to Cristian Silaghi from comment #9)
> Hi Théo,
>
> Why I get on the email "[Bugzilla] Your Outstanding Requests (1 feedback)".
> It's annoying.
Hi, you have to answer the request on the patch itself an turn the "fedback?" into "feedback+" or "feedback-", until that Bugzilla will keep reminding you about it each week. You can always clear those requests on attachments by clicking on "details". Clearing this one for you right now.
>
> I already asked here. Your hack is great. So I hope this change is merged.
Unfortunately no, as a ro localizer you had to merge this change into the Romanian gaia l10n repository for 1.2 (the same way you localize all the other strings). Sorry if it wasn't clear enough.
The good news is that 1.3 is not affected by this bug (just checked), so this patch is now useless and we can safely close this bug. No additional action is required from you.
Sorry for the inconvenience.
>
> Best Regards,
> Cristian Silaghi
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
Reporter | ||
Updated•11 years ago
|
Attachment #824095 -
Flags: feedback?(cristian.silaghi)
You need to log in
before you can comment on or make changes to this bug.
Description
•