Closed
Bug 932201
Opened 11 years ago
Closed 11 years ago
[B2G][DSDS] Gecko needs to properly download MMS for non-active SIM
Categories
(Firefox OS Graveyard :: RIL, defect, P1)
Tracking
(blocking-b2g:1.3+, firefox28 fixed)
People
(Reporter: airpingu, Assigned: airpingu)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
airpingu
:
review+
|
Details | Diff | Splinter Review |
This bug is specifically for Gecko part, which blocks bug 918558 (V1.3 user story).
Please see bug 918558, comment #6. We need to do:
1. When the MMS downloading mode is "automatic", for the non-active SIM, Gecko has to download the MMS as if "manual" mode.
2. When the user wants to manually download an MMS (by taping on the download button) that came from the non-active SIM, Gecko has to return an error code like "NonActiveSimCardError" to notify Gaia.
Assignee | ||
Updated•11 years ago
|
Blocks: b2g-multi-sim
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #823904 -
Flags: review?(ctai)
Assignee | ||
Comment 2•11 years ago
|
||
Note that this patch depends on bug 854326.
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 823904 [details] [diff] [review]
Patch
Review of attachment 823904 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/mobilemessage/src/gonk/MmsService.js
@@ +1636,5 @@
> }
>
> + // Under the "automatic" retrieval mode, for the non-active SIM, we have to
> + // download the MMS as if it is "manual" retrieval mode.
> + if (retrievalMode == RETRIEVAL_MODE_AUTOMATIC &&
Should be:
(retrievalMode == RETRIEVAL_MODE_AUTOMATIC || retrievalMode == RETRIEVAL_MODE_AUTOMATIC_HOME)
Attachment #823904 -
Flags: review?(ctai)
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #823904 -
Attachment is obsolete: true
Attachment #824527 -
Flags: review?(ctai)
Assignee | ||
Comment 6•11 years ago
|
||
Ping for review? :)
Updated•11 years ago
|
Attachment #824527 -
Flags: review?(ctai) → review+
Comment 7•11 years ago
|
||
Comment on attachment 824527 [details] [diff] [review]
Patch, V2
Review of attachment 824527 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me.
Attachment #824527 -
Flags: review+
Assignee | ||
Comment 8•11 years ago
|
||
r=ctai,vicamo
Attachment #824527 -
Attachment is obsolete: true
Attachment #827282 -
Flags: review+
Assignee | ||
Comment 9•11 years ago
|
||
Flags: in-testsuite-
Comment 10•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
status-firefox28:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•