Jose Manuel Cantera Reporter
	Description • 11 years ago

if you assign an empty array to a mozContact it does not take effect. 

let myMozContact be a contact which tel attr is not previously defined. 

myContact.tel is falsy 

myMozContact.tel = []

myContact.tel is still falsy and null

this is a bug and, as usual with WebIDL recent changes, is causing regressions in comms.

	Reuben Morais [:reuben] Assignee
	Comment 1 • 11 years ago

Hm, this indeed a bug in validateArrayField. ni? myself to look at this.

	Gregor Wagner [:gwagner]
	Comment 3 • 11 years ago

Reuben, can you add a test as well?

	Gregor Wagner [:gwagner]
	Comment 5 • 11 years ago

Comment on attachment 824662 [details] [diff] [review]
Allow empty arrays, with test. v2

Review of attachment 824662 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

	Reuben Morais [:reuben] Assignee
	Comment 6 • 11 years ago

https://hg.mozilla.org/integration/b2g-inbound/rev/3e4f6dd35a2b

	Reuben Morais [:reuben] Assignee
	Comment 7 • 11 years ago

aaand backed out for mochitest failures:
https://hg.mozilla.org/integration/b2g-inbound/rev/9ca5613535ab

	Reuben Morais [:reuben] Assignee
	Comment 8 • 11 years ago

https://hg.mozilla.org/integration/b2g-inbound/rev/a840636df700

	Ryan VanderMeulen [:RyanVM]
	Comment 9 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/a840636df700

	Joe Cheng [:jcheng] (please needinfo)
	Comment 10 • 11 years ago

resolved in master 1.3. remove flag