Closed Bug 933106 Opened 11 years ago Closed 7 years ago

Get rid of #ifdef MOZ_B2G in nsCocoaWindow.mm

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: mrbkap, Unassigned)

References

Details

In bug 923961 in order to get OMTC (and therefore cross process compositing) to work, we had to introduce a fairly ugly hack in order to make sure that the b2g-desktop window we create is opaque. This bug should track fixing things "properly," that is to say without an #ifdef.

In bug 923961 comment 14, Markus asked why the code in nsContainerFrame::SyncWindowProperties didn't do the trick. The proximate answer is that there's a check in SyncWindowProperties that bails out if the given window is not a XUL window. As b2g no longer uses a XUL window, but an HTML one instead (see bug 894927) we never set the window's opacity. I don't know if fixing that alone would fix the original problem, but it's probably the easiest place to start.
MOZ_B2G is no longer found in nsCocoaWindow.mm.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.