Closed
Bug 933176
Opened 11 years ago
Closed 4 years ago
Skip "obviously" non-tools directories during the tools tier
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: glandium, Assigned: glandium)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
The tools tier should not exist, I think we all agree. The sad reality is that it does, on the other hand, its use is mostly controlled. I suggest we don't make -C dir tools for all the directories that are not "obviously" tools dirs, which can be defined as having the is_tool_dir flag set, or having a Makefile.in containing more or less ".*tools.*::", which, IMHO, is safe enough.
|
Assignee | |
Comment 1•11 years ago
|
||
Sadly, at the moment, there are two tools rules in config/rules.mk. One for XPI_PKGNAME, and one for INSTALL_EXTENSION_ID.
|
|
Assignee | |
Comment 2•11 years ago
|
||
> or having a Makefile.in containing more or less ".*tools.*::", which, IMHO, is safe enough.
Actually, I think I can get rid of those.
|
|
Assignee | |
Comment 3•11 years ago
|
||
With bug 929298 and bug 933145, there are no tools rules left in Makefile.in, and all variables affecting tools will be in moz.build..
Attachment #826254 -
Flags: review?(gps)
|
|
Assignee | |
Comment 4•11 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #3)
> Created attachment 826254 [details] [diff] [review]
> Skip non-tools directories without variables in moz.build that are relevant
> to tools during this tier
>
> With bug 929298 and bug 933145
Err, bug 929298 and bug 934070.
|
||
Updated•11 years ago
|
Attachment #826254 -
Flags: review?(gps) → review+
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
|
|
Assignee | |
Comment 5•4 years ago
|
||
While not exactly the same, bug 1043344 addressed this without having to wait for the last pieces of Makefile using tools targets.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•