Closed
Bug 933207
Opened 11 years ago
Closed 11 years ago
B2G SMS & MMS: Fire system messages for the delivery reports
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(blocking-b2g:1.3+, firefox28 fixed)
People
(Reporter: airpingu, Assigned: airpingu)
References
Details
(Keywords: feature, Whiteboard: [ucid:Comms28, 1.3:p1])
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
airpingu
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
airpingu
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Comment 3•11 years ago
|
||
Comment on attachment 825778 [details] [diff] [review] Patch, V1 Review of attachment 825778 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/mobilemessage/src/gonk/MmsService.js @@ +1712,5 @@ > // TODO bug 832140 handle !Components.isSuccessCode(aRv) > > let topic; > if (mmsStatus === MMS.MMS_PDU_STATUS_RETRIEVED) { > topic = kSmsDeliverySuccessObserverTopic; How about add this.broadcastMmsSystemMessage(topic, aDomMessage); right here? @@ +1723,5 @@ > > + // Broadcasting a 'sms-delivery-success' system message to open apps. > + if (topic == kSmsDeliverySuccessObserverTopic) { > + this.broadcastMmsSystemMessage(topic, aDomMessage); > + } Delete these lines.
Attachment #825778 -
Flags: review?(ctai) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Thanks for the review. r=ctai
Attachment #825778 -
Attachment is obsolete: true
Attachment #825819 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Flags: in-testsuite-
Assignee | ||
Comment 6•11 years ago
|
||
Sorry. Miss one bit. Carry on r=ctai.
Attachment #825919 -
Flags: review+
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a048187c9151 https://hg.mozilla.org/mozilla-central/rev/e5c4fedbce6f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
status-firefox28:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•