Closed
Bug 933304
Opened 11 years ago
Closed 11 years ago
WebAudio equalpower panner does not handle gain (volume) correctly
Categories
(Core :: Web Audio, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: ojay, Assigned: karlt)
References
Details
Attachments
(5 files)
(deleted),
application/x-zip-compressed
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
padenot
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
padenot
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
padenot
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/30.0.1599.66 Safari/537.36
Steps to reproduce:
Play web audio with the following setup:
AudioNode -> GainNode -> Panner -> context.destination
panner.panningModel = "equalpower";
panner.setPosition(0, 0, -0.5);
GainNode.gain.value = 0;
Actual results:
gain is only applied to right channel of head phones.
So 0 gain is not applied to L channel, meaning you can still hear audio.
Expected results:
Should not be able to hear sound. Gain should be applied to all channels.
This may be related to previously resolved bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=849918
Note that if I connect the nodes in the opposite order, everything works as expected.
AudioNode -> Panner -> GainNode -> context.destination
Component: Untriaged → WebRTC: Audio/Video
Product: Firefox → Core
Updated•11 years ago
|
Status: UNCONFIRMED → NEW
Component: WebRTC: Audio/Video → Web Audio
Ever confirmed: true
Assignee | ||
Comment 3•11 years ago
|
||
Stereo gain is a bit more complex.
http://hg.mozilla.org/mozilla-central/annotate/effa95701c83/content/media/AudioNodeEngine.cpp#l212
The gain should be applied together with distance and cone gain.
http://hg.mozilla.org/mozilla-central/annotate/effa95701c83/content/media/webaudio/PannerNode.cpp#l366
Blocks: 864609
Priority: -- → P1
Assignee | ||
Comment 4•11 years ago
|
||
Assignee: nobody → karlt
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•11 years ago
|
||
Attachment #8365475 -
Flags: review?(paul)
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #8365476 -
Flags: review?(paul)
Assignee | ||
Comment 7•11 years ago
|
||
Attachment #8365477 -
Flags: review?(paul)
Updated•11 years ago
|
Attachment #8365475 -
Flags: review?(paul) → review+
Updated•11 years ago
|
Attachment #8365476 -
Flags: review?(paul) → review+
Updated•11 years ago
|
Attachment #8365477 -
Flags: review?(paul) → review+
Assignee | ||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b9dfa78a4c7
https://hg.mozilla.org/integration/mozilla-inbound/rev/be857f605b78
https://hg.mozilla.org/integration/mozilla-inbound/rev/6cf335169e81
https://hg.mozilla.org/integration/mozilla-inbound/rev/9af6d5c67f34
Flags: in-testsuite+
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2b9dfa78a4c7
https://hg.mozilla.org/mozilla-central/rev/be857f605b78
https://hg.mozilla.org/mozilla-central/rev/6cf335169e81
https://hg.mozilla.org/mozilla-central/rev/9af6d5c67f34
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•