Closed
Bug 933579
Opened 11 years ago
Closed 11 years ago
Export IsVideoContentType() to VideoUtils
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: cpearce, Assigned: cpearce)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
(deleted),
patch
|
kinetik
:
review+
|
Details | Diff | Splinter Review |
In my patches for bug 908503 I need to use IsVideoContentType() outside of WMFReader, so we may as well move it to VideoUtils where it can be used elsewhere. We can also move VideoUtils into namespace mozilla, currently not all of it is inside namespace mozilla.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #825697 -
Flags: review?(kinetik)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 825697 [details] [diff] [review]
Patch
+bool
+IsVideoContentType(const nsCString& aContentType);
No newline between bool and function name for the decl.
Attachment #825697 -
Flags: review?(kinetik) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Landed with review comment addressed.
https://hg.mozilla.org/integration/mozilla-inbound/rev/a833c2e9b95e
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•