Closed
Bug 933591
Opened 11 years ago
Closed 11 years ago
[Gaia] NFC Manager implemenation
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 860910
People
(Reporter: dgarnerlee, Unassigned)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
The NFC manager routes NDEF data to applications.
|
Reporter | |
Comment 1•11 years ago
|
||
Attachment #825720 -
Flags: review?
|
||
Comment 2•11 years ago
|
||
Hi Garner,
The current patch doesn't handle tech-discovered messages with no NDEF messages. The error is shown in [1]. Please have a look at the attached fix, which resolves the problem for me. If no NDEF messages are attached, a 'tag-discovered' activity will be generated.
[1] https://bugzilla.mozilla.org/show_bug.cgi?id=916863#c22
Attachment #830907 -
Flags: feedback?(dgarnerlee)
|
|
Reporter | |
Comment 3•11 years ago
|
||
Comment on attachment 830907 [details] [diff] [review]
0001-Support-empty-NDEF-array-in-System-app.patch
Review of attachment 830907 [details] [diff] [review]:
-----------------------------------------------------------------
Seems good. I'll need to check it against the newer uint8arry version of the nfc_mangager though...(we're going to merge 2 feature branches in soon-ish to master hopefully: uint8array updates, and onpeerfound/lost).
Related, please repost to Bug 860910 (the much more active duplicate of this bug), until incorporated.
|
||
Comment 4•11 years ago
|
||
Close according to comment3.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
|
|
Reporter | |
Comment 5•11 years ago
|
||
Comment on attachment 830907 [details] [diff] [review]
0001-Support-empty-NDEF-array-in-System-app.patch
Patch applied to SVIC's Gaia master.
Attachment #830907 -
Flags: feedback?(dgarnerlee)
|
||
Updated•11 years ago
|
Attachment #825720 -
Flags: review?
You need to log in
before you can comment on or make changes to this bug.
Description
•