Closed
Bug 933649
Opened 11 years ago
Closed 11 years ago
Group methods in editor.js for better self-documentation
Categories
(DevTools :: Source Editor, defect)
DevTools
Source Editor
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 28
People
(Reporter: vporof, Assigned: vporof)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
(deleted),
patch
|
anton
:
review+
|
Details | Diff | Splinter Review |
I've been working with our editor lately. Skimming for methods in editor.js is very hard at the moment, because methods with similar or related functionality are dispersed all around the file.
It would be helpful for newcomers (and me) if related methods would be grouped together. For example, setting text, selection in one place, converting coords, offsets in another, etc.
|
Assignee | |
Comment 1•11 years ago
|
||
Simply moves methods around.
|
||
Comment 2•11 years ago
|
||
Comment on attachment 825766 [details] [diff] [review]
editor-group.patch
Review of attachment 825766 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM.
Attachment #825766 -
Flags: review?(anton) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Whiteboard: [fixed-in-fx-team]
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•