Closed Bug 933811 Opened 11 years ago Closed 6 years ago

Missing switch-to-tab functionality in the Top Sites thumbnails pane of about:home

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect, P5)

Product:
Firefox for Android Graveyard
Component:
Awesomescreen
Version:
26 Branch
Platform:
ARM
Android
Type:
defect

Tracking

(firefox26 affected, firefox27 affected, firefox28 affected, firefox32 affected, firefox33 affected, firefox34 affected, firefox35 affected, fennec+, firefox62 wontfix, firefox63 wontfix, firefox64 wontfix, firefox65 wontfix, firefox66 wontfix)

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox26 --- affected
firefox27 --- affected
firefox28 --- affected
firefox32 --- affected
firefox33 --- affected
firefox34 --- affected
firefox35 --- affected
fennec + ---
firefox62 --- wontfix
firefox63 --- wontfix
firefox64 --- wontfix
firefox65 --- wontfix
firefox66 --- wontfix

People

(Reporter: aaronmt, Unassigned)

References

Details

Bug 917396 implemented a top-sites grid in the new about:home but it seems like switch-to-tab is not wired up properly for thumbnails. We *do* show it for the listing of items underneath the thumbnails, but we do an unnecessary page reload for items of which are currently open in existing tabs from the existing thumbnail positions on about:home. The history pane has switch-to-tab wired properly for the open tabs.
Note: This is not a regression. The old about:home also does not do switch-to-tab from the top-sites thumbnails grid.
Teodora, can you update MozTrap #8083 to make sure that we acknowledge that this feature does not exist yet?
Flags: needinfo?(teodora.vermesan)
Assignee: nobody → margaret.leibovic
I was confused about this bug when I initially read the description, I thought the issue was that we weren't showing "Switch to tab" for list items on the top sites page. I don't think we should switch to open tabs for thumbnails unless we have some sort of "Switch to tab" indicator. Ian, what do you think we should do?
Flags: needinfo?(ibarlow)
Yeah, we would need some kind of indicator there. I have to think about what that might look like though, given our limited space and that we already might have a Pin icon on the thumbnail as well...
Flags: needinfo?(ibarlow)
tracking-fennec: ? → +
I'm not currently working on this, but it still needs some UX attention before any development can happen.
Assignee: margaret.leibovic → nobody
Removing my needinfo request untill they decide how the feature looks like. Aaron please set back the flag when it is resolved fixed.
Flags: needinfo?(teodora.vermesan)
(In reply to :Margaret Leibovic from comment #7) > I'm not currently working on this, but it still needs some UX attention > before any development can happen. +CC Yuan/Alam Perhaps this can be mentored?
filter on [mass-p5]
Priority: -- → P5
This could be a signal we surface in our top sites. Making it block the right Meta.
Blocks: home-panels
No longer blocks: 1063058
This issue occurs on the old version of about:home. For now, we have an issue who is related to the actual about:home -> Top Sites. I'll close this issue as a duplicate of bug 1428017, thanks.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
Upon further investigation, I will close this issue as Works for me due to the difference between this issue and the other one who is logged on the Activity Stream functionality, thanks.
Resolution: DUPLICATE → WORKSFORME
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.