Closed
Bug 934503
Opened 11 years ago
Closed 11 years ago
Activated hidden plugins (Flash) show the blue plugin icon
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(firefox26+ verified, firefox27+ verified, firefox28 verified, b2g-v1.2 fixed)
VERIFIED
FIXED
mozilla28
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
(Keywords: regression)
Attachments
(2 files)
(deleted),
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
The blue plugin notification icon is only supposed to be shown when the plugin is not active. In today's nightly http://benjamin.smedbergs.us/tests/ctptests/flash-hidden.html shows the blue icon. This is a regression from bug 745187. I think I already have it fixed in another prototype in my tree, but I'm going to try and split it out to get it fixed now.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #826946 -
Flags: review?(jaws)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → benjamin
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #826961 -
Flags: review?(jaws)
Updated•11 years ago
|
Attachment #826961 -
Flags: review?(jaws) → review+
Updated•11 years ago
|
Attachment #826946 -
Flags: review?(jaws) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/a8131d677d9b
https://hg.mozilla.org/integration/fx-team/rev/f631148645b3
This will be uplifted with the patch that regressed it.
Target Milestone: --- → mozilla28
Backed out in https://hg.mozilla.org/integration/fx-team/rev/b0bce439c6e2 for a failing browser-chrome test: https://tbpl.mozilla.org/php/getParsedLog.php?id=30103597&tree=Fx-Team
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Assignee | ||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/8da8761dab7d
https://hg.mozilla.org/releases/mozilla-beta/rev/2cdb3f4cd18f
Comment 7•11 years ago
|
||
status-b2g-v1.2:
--- → fixed
Comment 8•11 years ago
|
||
Verified as fixed using the following environment:
FF 26 beta 3
Build identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build Id:20131107161719
OS: Win 7 x64
Comment 9•11 years ago
|
||
(In reply to Benjamin Smedberg [:bsmedberg] from comment #0)
> The blue plugin notification icon is only supposed to be shown when the
> plugin is not active. In today's nightly
> http://benjamin.smedbergs.us/tests/ctptests/flash-hidden.html shows the blue
> icon.
Still remains blue if Flash is CTP blocked and allowing. But it gets normal after refresh.
What do you think?
Flags: needinfo?(benjamin)
Assignee | ||
Comment 10•11 years ago
|
||
Do you mean that if flash is blocked, and then you allow it via the doorhanger, the icon remains blue? I think that's the expected behavior.
Flags: needinfo?(benjamin)
Comment 11•11 years ago
|
||
But that means the plugin is active, so it's contrary to:
(In reply to Benjamin Smedberg [:bsmedberg] from comment #0)
> The blue plugin notification icon is only supposed to be shown when the
> plugin is not active.
Assignee | ||
Comment 12•11 years ago
|
||
Once we've shown the icon, we don't want to change it until the next page load. It would be weird flickering.
Comment 13•11 years ago
|
||
Thanks for explaining.
Verified fixed 28.0a1 (2013-11-10) Win 7
Comment 14•11 years ago
|
||
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0
Verified as fixed on latest Aurora 27.0a2 (buildID: 20131121004004).
Keywords: verifyme
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•