Closed Bug 934727 Opened 11 years ago Closed 10 years ago

Use xhr.addEventListener in l10n.js

Categories

(Firefox OS Graveyard :: Gaia::L10n, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::L10n
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.0 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S1 (9may)
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: zbraniecki, Assigned: zbraniecki)

References

Details

Attachments

(3 files)

patch, l10n part
(deleted), patch
stas
: review+
Details | Diff | Splinter Review
patch, gaia part
(deleted), patch
stas
: review+
Details | Diff | Splinter Review
pull request
(deleted), text/x-github-pull-request
Details 
This is an offspring of bug 914414. We want to use xhr eventListeners but that requires changes to bto, so we'll deal with it as a followup to that bug here.
Assignee: nobody → gandalf
Depends on: 914414
OS: Mac OS X → All
Hardware: x86 → All
Component: Gaia → Gaia::L10n
Attached patch patch, l10n part (deleted) — — Splinter Review 

        Attachment #8404195 -
        Flags: review?(stas)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch, gaia part (deleted)
        — 
          — Splinter Review
      

    


  

        Attachment #8404196 -
        Flags: review?(stas)

    
    

    
  
Comment on attachment 8404195 [details] [diff] [review]
patch, l10n part

Review of attachment 8404195 [details] [diff] [review]:
-----------------------------------------------------------------

So much nicer. r=me.

        Attachment #8404195 -
        Flags: review?(stas) → review+

        Attachment #8404196 -
        Flags: review?(stas) → review+

    
    

    
  

      
      
      
      

        Attached file
          
        pull request (deleted)
        — 
      

    


  

        Attachment #8405205 -
        Flags: review?(21)

    
    

    
  
Comment on attachment 8405205 [details]
pull request

For this type of changes, that does not really change any behaviors or API, please consider that you don't need me as long you're careful with memory/perf.

        Attachment #8405205 -
        Flags: review?(21)

    
    

    
  
Thank, Vivien, this will help streamline the process.

Gandalf, it looks like the tests don't pass with this pull request:

https://travis-ci.org/mozilla-b2g/gaia/jobs/22751188#L2549

It might have something to do with Sinon's FakeXHR:

https://github.com/mozilla-b2g/gaia/blob/5c56b25486e2b9ac438ef9c3a7825ed4445d5b34/apps/gallery/test/unit/l10n/l10n_test.js#L54
Depends on: 995425

    
    

    
  
(In reply to Staś Małolepszy :stas from comment #6)
> It might have something to do with Sinon's FakeXHR:
> 
> https://github.com/mozilla-b2g/gaia/blob/
> 5c56b25486e2b9ac438ef9c3a7825ed4445d5b34/apps/gallery/test/unit/l10n/
> l10n_test.js#L54

Good catch. Upgrading sinon to 1.9.1 fixed tests. Filed bug 995425.

    
    

    
  
ok, travis is happy with the updated sinon. Let's land this.
Status: NEW → ASSIGNED

    
    

    
  
Bug 995425 bounced, so I assume this shouldn't land yet.
Keywords: checkin-needed

    
    

    
  
Master: https://github.com/mozilla-b2g/gaia/commit/b6d1c7fae27ec22ee06e3da7898fe2565fc0a8c0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago

          status-b2g-v2.0:
          --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S1 (9may)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: