Closed
Bug 934906
Opened 11 years ago
Closed 11 years ago
[Flatfish] Dock disappears
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(blocking-b2g:1.3+)
VERIFIED
FIXED
blocking-b2g | 1.3+ |
People
(Reporter: atsai, Assigned: gduan)
References
Details
(Whiteboard: [Flatfish][developer+])
Attachments
(2 files)
Dock disappear after reboot
** The case is by the testing on Flatfish devices. It might not be able to reproduce on other mobile devices **
Gaia: ac7cf6a73231b3e30fb065c2f38f69c4f5926caa
Gecko: facaf2461856789476876566b60b5af461a59b79
BuildID 20131105111940
Version 28.0a1
Updated•11 years ago
|
Whiteboard: [Flatfish] → [Flatfish][developer+]
Reporter | ||
Comment 1•11 years ago
|
||
Confirmed, it's still reproducible.
Gaia: e95ab38f3c7ea2834e92f4ff37143432f0312a71
Gecko: 7a9d20c22caf534b027f69ffd5e4a274be8c66b7
BuildID 20131106064537
Version 28.0a1
Assignee | ||
Comment 2•11 years ago
|
||
bug 935547 can bring us the correct layout for homescreen, but the dock bar is still hidden.
I tried to dump the screen.width/height and window.innerHeight/innerWidth values from homescreen and found out that..
01-03 07:41:29.790: E/GeckoConsole(1640): Content JS LOG at app://homescreen.gaiamobile.org/js/homescreen.js:5 in Homescreen<: window inner height is 780
01-03 07:41:29.790: E/GeckoConsole(1640): Content JS LOG at app://homescreen.gaiamobile.org/js/homescreen.js:6 in Homescreen<: window screen height is 1280
01-03 07:41:29.790: E/GeckoConsole(1640): Content JS LOG at app://homescreen.gaiamobile.org/js/homescreen.js:7 in Homescreen<: window inner width is 1280
01-03 07:41:29.790: E/GeckoConsole(1640): Content JS LOG at app://homescreen.gaiamobile.org/js/homescreen.js:8 in Homescreen<: window screen width is 800
So, based on https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/style/homescreen.css#L152,
the dock bar will set to hidden.
Assignee: nobody → gduan
Assignee | ||
Comment 3•11 years ago
|
||
Hi Cristian,
since homescreen's device-height is 1280px and the default orientation is landscape, I need to update the mediaquery in homescreen.css in order to fix this bug.
Please kindly check.
Thanks.
Attachment #828085 -
Flags: review?(crdlc)
Comment 4•11 years ago
|
||
Comment on attachment 828085 [details]
PR to master
Perfect from my side my mate
Attachment #828085 -
Flags: review?(crdlc) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Thanks, Cristian.
Merged into master,
https://github.com/mozilla-b2g/gaia/commit/0c1587ab2972fdad187f5daba7b60c01c30a9992
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 6•11 years ago
|
||
Gaia: 4a0bb67204572affcbf1afb384d2ffdc8261e977
Gecko: e42dac2ae79959eadd8d832c715e430ada8d64cc
BuildID 20131108064537
Version 28.0a1
Status: RESOLVED → VERIFIED
Updated•11 years ago
|
blocking-b2g: koi? → 1.3?
Updated•11 years ago
|
blocking-b2g: 1.3? → 1.3+
You need to log in
before you can comment on or make changes to this bug.
Description
•