Closed
Bug 935037
Opened 11 years ago
Closed 11 years ago
Remove multi-touch perf opt from MetroInput
Categories
(Core Graveyard :: Widget: WinRT, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla28
People
(Reporter: jimm, Assigned: jimm)
References
Details
Attachments
(1 file)
(deleted),
patch
|
TimAbraldes
:
review+
|
Details | Diff | Splinter Review |
This is having an adverse effect on apzc responsiveness. Also I don't think this is needed anymore now that we have the HasPointMoved optimization. Another issue is that we delay sending touch moves until the first touch point position has changed, which delays the sending of all touch points.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee: nobody → jmathies
Attachment #827438 -
Flags: review?(tabraldes)
Comment 2•11 years ago
|
||
Comment on attachment 827438 [details] [diff] [review] patch Review of attachment 827438 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me! ::: widget/windows/winrt/MetroInput.cpp @@ +572,5 @@ > touch->mChanged = true; > // replacing old touch point in mTouches map > mTouches.Put(pointerId, touch); > > + AddPointerMoveDataToRecognizer(aArgs); Seems like you could move this above line 565, and remove line 567
Attachment #827438 -
Flags: review?(tabraldes) → review+
Assignee | ||
Comment 3•11 years ago
|
||
updated per comments. https://hg.mozilla.org/integration/fx-team/rev/b0c2bafe0fec
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b0c2bafe0fec
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•5 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•