See attachment. APZController.cpp has a compile error but it's not telling me what. Sorry for the bad line-wrapping. If I run mach build --verbose widget/windows/winrt then it tells me what the compile errors are, but that shouldn't really be necessary.

This could definitely be approved.

I'm sure this is one of the numerous pymake eats my output bugs. Just quit using pymake and use mozmake instead. https://bugzilla.mozilla.org/show_bug.cgi?id=927213#c5

I think this happens only for pymake native commands, and it is caused by pymake's use of multiprocessing. Multiprocessing's child processes exit with os._exit, so if they get shut down before std* files are flushed the command output gets lost. The attached patch should fix this issue.

Note: the patch is based on top of os.environ cleaning patch from bug 933558, I can rebase it if needed.

Ups, it looks like this is a dupe of bug 925270, at least my patch is fixing the issue described there.

Comment on attachment 828493 [details] [diff] [review] manually flush native command's stdout and stderr, multiprocessing exits via os._exit. Review of attachment 828493 [details] [diff] [review]: ----------------------------------------------------------------- Oh, pymake.

Here is a patch for checkin, it should apply cleanly to mozilla-central. I rebased it so that it doesn't depend on patch from bug 933558, this bug seems more urgent.

And here is a patch for https://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake , if I understand correctly the patches to pymake need to land to both repositories. Could someone please check these in for me, or set the checkin-needed flag?

https://hg.mozilla.org/integration/mozilla-inbound/rev/4c604a710122 https://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/42627616700c