Closed
Bug 935050
Opened 11 years ago
Closed 11 years ago
Windows incremental build with mach doesn't provide error messages
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla28
People
(Reporter: kats, Assigned: ziga.seilnacht)
References
Details
Attachments
(4 files)
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
See attachment. APZController.cpp has a compile error but it's not telling me what. Sorry for the bad line-wrapping.
If I run mach build --verbose widget/windows/winrt then it tells me what the compile errors are, but that shouldn't really be necessary.
Comment 2•11 years ago
|
||
I'm sure this is one of the numerous pymake eats my output bugs. Just quit using pymake and use mozmake instead. https://bugzilla.mozilla.org/show_bug.cgi?id=927213#c5
Assignee | ||
Comment 3•11 years ago
|
||
I think this happens only for pymake native commands, and it is caused by pymake's use of multiprocessing. Multiprocessing's child processes exit with os._exit, so if they get shut down before std* files are flushed the command output gets lost.
The attached patch should fix this issue.
Attachment #828493 -
Flags: review?(gps)
Assignee | ||
Comment 4•11 years ago
|
||
Note: the patch is based on top of os.environ cleaning patch from bug 933558, I can rebase it if needed.
Assignee | ||
Comment 5•11 years ago
|
||
Ups, it looks like this is a dupe of bug 925270, at least my patch is fixing the issue described there.
Comment 6•11 years ago
|
||
Comment on attachment 828493 [details] [diff] [review]
manually flush native command's stdout and stderr, multiprocessing exits via os._exit.
Review of attachment 828493 [details] [diff] [review]:
-----------------------------------------------------------------
Oh, pymake.
Attachment #828493 -
Flags: review?(gps) → review+
Assignee | ||
Comment 8•11 years ago
|
||
Here is a patch for checkin, it should apply cleanly to mozilla-central. I rebased it so that it doesn't depend on patch from bug 933558, this bug seems more urgent.
Attachment #828967 -
Flags: checkin?
Assignee | ||
Comment 9•11 years ago
|
||
And here is a patch for https://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake , if I understand correctly the patches to pymake need to land to both repositories.
Could someone please check these in for me, or set the checkin-needed flag?
Attachment #828968 -
Flags: checkin?
Updated•11 years ago
|
Attachment #828967 -
Flags: checkin? → checkin+
Updated•11 years ago
|
Attachment #828968 -
Flags: checkin? → checkin+
Comment 10•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c604a710122
https://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/42627616700c
Assignee: nobody → ziga.seilnacht
Comment 11•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•