Closed Bug 935081 Opened 11 years ago Closed 11 years ago

[Download Manager] New shared component DownloadLauncher

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
1.3 Sprint 5 - 11/22

People

(Reporter: crdlc, Assigned: crdlc)

References

Details

(Whiteboard: [systemsfe][qa-])

Attachments

(1 file)

Patch v1
(deleted), text/html
arcturus
: review+
Details
This library will receive the download object and will provide with a mechanism to open files (basically via MozActivities) This library will be available in shared/js/download because it could be used in download list view, notifications and banner
Blocks: 935088
Blocks: 935094
Blocks: 935098
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Summary: Bug 935070 - [Download Manager] New shared component DownloadLauncher → [Download Manager] New shared component DownloadLauncher
Attached file Patch v1 (deleted) —
Attachment #828956 - Flags: review?(francisco.jordano)
Comment on attachment 828956 [details] Patch v1 Some comments on github but are just informative. Pretty nice job mate!
Attachment #828956 - Flags: review?(francisco.jordano) → review+
An example of the comment about not always storing on the sdcard: https://bugzilla.mozilla.org/show_bug.cgi?id=936342 We are doing that job there, so we will need to check where the downloads are going to :)
Comment on attachment 828956 [details] Patch v1 Sorry, after reviewing work on bug 936342 it's clear to me that we can download archives even if we don't have sdcard, so we will need to be ready from the begining to deal with archives stored internally. :( will try to figure out how that affects to our code.
Attachment #828956 - Flags: review+ → review-
Target Milestone: --- → 1.3 Sprint 5 - 11/22
Comment on attachment 828956 [details] Patch v1 Asking for a new review mate, thanks
Attachment #828956 - Flags: review- → review?(francisco.jordano)
Comment on attachment 828956 [details] Patch v1 Great job Cristian! Thanks for addressing all the comments.
Attachment #828956 - Flags: review?(francisco.jordano) → review+
Thanks to you for your review https://github.com/mozilla-b2g/gaia/commit/fd3ef7ca46059efcdf78051c7223292c6de61b9e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Whiteboard: [systemsfe] → [systemsfe][qa-]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: