Closed
Bug 935297
Opened 11 years ago
Closed 11 years ago
Add Moz2D API to stream paths into an arbitrary sink
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: bas.schouten, Assigned: bas.schouten)
References
Details
(Whiteboard: [qa-])
Attachments
(5 files)
(deleted),
patch
|
mattwoodrow
:
review+
mattwoodrow
:
checkin+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mattwoodrow
:
review+
mattwoodrow
:
checkin+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mattwoodrow
:
review+
mattwoodrow
:
checkin+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mattwoodrow
:
review+
mattwoodrow
:
checkin+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jrmuizel
:
review+
bas.schouten
:
review+
|
Details | Diff | Splinter Review |
We should add an API to stream paths into an arbitrary sinks. This will make it easier for backends to use path objects across backends if so desired, as well as allow a more elegant (more cross-backend) implementation of path flattening.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #827714 -
Flags: review?(matt.woodrow)
Updated•11 years ago
|
Attachment #827714 -
Flags: review?(matt.woodrow) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #827746 -
Flags: review?(matt.woodrow)
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #827747 -
Flags: review?(matt.woodrow)
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #827748 -
Flags: review?(matt.woodrow)
Comment 5•11 years ago
|
||
Attachment #827777 -
Flags: review?(jmuizelaar)
Updated•11 years ago
|
Attachment #827746 -
Flags: review?(matt.woodrow) → review+
Updated•11 years ago
|
Attachment #827747 -
Flags: review?(matt.woodrow) → review+
Updated•11 years ago
|
Attachment #827748 -
Flags: review?(matt.woodrow) → review+
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d4aa5d0e7431
https://hg.mozilla.org/integration/mozilla-inbound/rev/95da3889f8fa
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce50e7246684
https://hg.mozilla.org/integration/mozilla-inbound/rev/552952fcc560
Whiteboard: [leave open]
Updated•11 years ago
|
Attachment #827714 -
Flags: checkin+
Updated•11 years ago
|
Attachment #827746 -
Flags: checkin+
Updated•11 years ago
|
Attachment #827747 -
Flags: checkin+
Updated•11 years ago
|
Attachment #827748 -
Flags: checkin+
Comment 7•11 years ago
|
||
Assignee | ||
Comment 8•11 years ago
|
||
Comment on attachment 827777 [details] [diff] [review]
Part 5: Implement StreamToSink on CG.
Review of attachment 827777 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/2d/PathCG.cpp
@@ +172,5 @@
> + switch (element->type) {
> + case kCGPathElementMoveToPoint:
> + {
> + CGPoint pt = element->points[0];
> + sink->MoveTo(Point(pt.x, pt.y));
Please add a helper like CGPointToPoint or something along those lines so we can prevent all these ugly temps :).
Attachment #827777 -
Flags: review+
Updated•11 years ago
|
Attachment #827777 -
Flags: review?(jmuizelaar) → review+
Comment 9•11 years ago
|
||
Comment 10•11 years ago
|
||
Whiteboard: [leave open]
Comment 11•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•