Closed
Bug 935596
Opened 11 years ago
Closed 11 years ago
nsJARInputStream crashes debug builds when it encounters a corrupt zip file
Categories
(Core :: Networking: JAR, defect)
Core
Networking: JAR
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: mossop, Assigned: mossop)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
(deleted),
patch
|
taras.mozilla
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
If the CRC check fails it asserts.
|
Assignee | |
Comment 1•11 years ago
|
||
I don't think there is any reason to break in debug builds for this case, we don't for other cases of zip corruption like bad central directory structures.
Attachment #828336 -
Flags: review?(taras.mozilla)
|
||
Updated•11 years ago
|
Attachment #828336 -
Flags: review?(taras.mozilla) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 828336 [details] [diff] [review]
patch
[Approval Request Comment]
Bug caused by (feature/regressing bug #): N/A
User impact if declined: We can't land the test for bug 932361
Testing completed (on m-c, etc.): Multiple days on m-c
Risk to taking this patch (and alternatives if risky): No risk, this is a debug build only change
String or IDL/UUID changes made by this patch: None
Attachment #828336 -
Flags: approval-mozilla-aurora?
|
||
Updated•11 years ago
|
Attachment #828336 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
||
Comment 5•11 years ago
|
||
status-firefox27:
--- → fixed
status-firefox28:
--- → fixed
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•