Closed
Bug 935690
Opened 11 years ago
Closed 11 years ago
Document::InitCSP should not ignore return value of SetCsp
Categories
(Core :: Security, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: deian, Assigned: deian)
References
(Blocks 1 open bug)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Following up on bug 919587 comment 10 and
bug 886164 comment 39:
We need to make sure that InitCSP checks handles failure of SetCSP in:
https://mxr.mozilla.org/mozilla-central/source/content/base/src/nsDocument.cpp#2723
Unfortunatelly, just failing when SetCsp fails reintroduces bug 919587.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → deian
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Try is good: https://tbpl.mozilla.org/?tree=Try&rev=729bee837023
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8335832 -
Flags: review?(bzbarsky)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8335832 [details] [diff] [review]
0001-Bug-935690-InitCSP-checks-SetCsp-failure.patch
So this is OK now because data documents no longer InitCSP, right?
r=me
Attachment #8335832 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
(In reply to Boris Zbarsky [:bz] from comment #3)
> Comment on attachment 8335832 [details] [diff] [review]
> 0001-Bug-935690-InitCSP-checks-SetCsp-failure.patch
Thanks to looking at all my trivial patches!
> So this is OK now because data documents no longer InitCSP, right?
Yes, that's right. I just tried the email client on b2g with this patch, the patch for bug 941404, and bug 88616; the issue reported in bug 919587 did not reappear.
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 5•11 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•