Closed
Bug 935833
Opened 11 years ago
Closed 11 years ago
[Flatfish] [System] Make sleep menu not fill full screen
Categories
(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gasolin, Assigned: gasolin)
References
Details
Attachments
(3 files, 2 obsolete files)
sleep menu UI spec
let shutdown menu (menu appeared after long press power button) use modal dialog instead
|
Assignee | |
Updated•11 years ago
|
|
|
Assignee | |
Updated•11 years ago
|
Summary: [Flatfish] [System] Make shutdown menu not fill full screen → [Flatfish] [System] Make sleep menu not fill full screen
|
|
Assignee | |
Comment 1•11 years ago
|
||
UI is in Settings Spec https://bugzilla.mozilla.org/attachment.cgi?id=827809
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → gasolin
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
|
Assignee | |
Comment 3•11 years ago
|
||
WIP, main layout ready, need adjust Header and add tablet specific icons
|
|
Assignee | |
Comment 4•11 years ago
|
||
Fang, according to UI spec, the main container is 39rem, with 4 column items which are 4.7rem height and 3rem top margin, they occupied
5*3(5 margin include 1 bottom margin) + 4.7*4 (4 items)
= 33.8rem
which means the title could only use 39-33.8 = 5.2rem
Attached file is the screenshot with this setup. Please help check if its a proper result, or kindly provide new numbers.
Flags: needinfo?(fshih)
|
|
Assignee | |
Comment 5•11 years ago
|
||
per offline discussion, the first list item has 3rem margin and others has 2.4rem margin.
Add the icon for tablet menu, ready for review
Attachment #832164 -
Attachment is obsolete: true
Attachment #832208 -
Attachment is obsolete: true
Attachment #832905 -
Flags: review?(alive)
Flags: needinfo?(fshih)
|
|
Assignee | |
Comment 6•11 years ago
|
||
|
||
Comment 7•11 years ago
|
||
Comment on attachment 832905 [details]
pull request redirect to github
r+ if you change the rule to data-value
Attachment #832905 -
Flags: review?(alive) → review+
|
|
Assignee | |
Comment 8•11 years ago
|
||
Update to use [data-value="xxx"] syntax in style,
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/9e3012065962019fa86448daa83b60a9072e9093
thanks!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•