Closed
Bug 936111
(camera-parameters)
Opened 11 years ago
Closed 7 years ago
[Camera] Refactor camera configuration management
Categories
(Firefox OS Graveyard :: Gaia::Camera, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: mikeh, Assigned: mikeh)
References
Details
Attachments
(1 file, 1 obsolete file)
The current CameraControl implementation maintains a single CameraParameters set. Every property change by the app (e.g. flashMode='on') modifies this set which is then pushed to the camera driver in its entirety.
The function that handles this[1] then parses the parameter set and updates the camera settings.
It would be more efficient to only pass in the modified parameters to minimize the number of transactions with the driver.
Unfortunately, the parameter handling is erratic. Depending on the parameter in question, some missing values are completely ignored[2], some show up in the logcat as errors[3], and some have default values (usually 0) used[4].
1. https://www.codeaurora.org/cgit/quic/la/platform/hardware/qcom/camera/tree/QualcommCameraHardware.cpp?h=aosp-new/ics#n6149
2. https://www.codeaurora.org/cgit/quic/la/platform/hardware/qcom/camera/tree/QualcommCameraHardware.cpp?h=aosp-new/ics#n9123
3. https://www.codeaurora.org/cgit/quic/la/platform/hardware/qcom/camera/tree/QualcommCameraHardware.cpp?h=aosp-new/ics#n7994
4. https://www.codeaurora.org/cgit/quic/la/platform/hardware/qcom/camera/tree/QualcommCameraHardware.cpp?h=aosp-new/ics#n8242
Assignee | ||
Updated•10 years ago
|
Blocks: camera-backlog
Assignee | ||
Updated•10 years ago
|
Alias: camera-parameters
Comment 2•7 years ago
|
||
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•