Closed Bug 936272 Opened 11 years ago Closed 11 years ago

Avoid calling mkdir() from content process in form mochitests.

Categories

(Core :: DOM: Core & HTML, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: jld, Assigned: jld)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch bugNNNNNN-seccomp-mochitest-mkdir.diff (obsolete) (deleted) — Splinter Review
Context: I'm trying to get mochitests to pass on the B2G emulator with content process sandboxing (seccomp-bpf) enabled, so that we can enable sandboxing in TBPL. Currently we're allowing open(), but the eventual plan is to make its callers request file access through the parent process, and we don't allow a content process to call mkdir(). Problem: Some of the forms tests use FileUtils to create files (either via MockFilePicker.useAnyFile or directly), and FileUtils tries to create a file's enclosing directory even if it already exists. I've attached one possible solution, which avoids trying to create TmpD, under the assumption that it will already exist at this point. I've tested this assumption with a try run: https://tbpl.mozilla.org/?tree=Try&rev=508f4e0290c1 Thoughts?
Comment on attachment 828969 [details] [diff] [review] bugNNNNNN-seccomp-mochitest-mkdir.diff I'm thinking we can check this in now, to unblock getting seccomp on tinderbox, and fix things for real later.
Attachment #828969 - Flags: review?(jonas)
Improving commit message; content of patch unchanged. Carrying over r=sicking.
Attachment #828969 - Attachment is obsolete: true
Attachment #8335717 - Flags: review+
→ b2g-inbound.
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Component: HTML: Form Submission → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: