STR: • Settings > Call Settings > Fixed dialing numbers • make sure FDN is enabled • Authorized numbers • add a new FDN contact, tap [OK] • enter the correct PIN2 Expected: • contact is added to the FDN contact list Actual: • the FDN contact list is not changed Tested with Gecko 28 (20131106164831) and Gaia master (ac2c668). This might be a Gecko regression: it looks like the `navigator.mozIccManager.updateContact' method works fine when updating a contact but does not allow to create a new contact any more.

I'll check this, thanks Kaze.

Thank *you*! :-)

Just flashed latest gaia, seems met Bug 936324 now. Kaze, I cannot find the gaia commit in Comment 0, (ac2c668) $git checkout ac2c668 error: pathspec 'ac2c668' did not match any file(s) known to git.

Ugh, 'ac2c668' is my local branch. :-$ I meant “latest Gaia”. E.g. this bug still happens with Gaia 275ca2c. https://github.com/mozilla-b2g/gaia/commit/275ca2c

Kaze, can you show me your gecko commit as well? seems the keyboard is broken now and it's caused by gecko. (From the comment in Bug 936324) :(

(In reply to Yoshi Huang[:allstars.chh][:yoshi] from comment #5) > Kaze, can you show me your gecko commit as well? seems the keyboard is > broken now and it's caused by gecko. (From the comment in Bug 936324) :( Never mind, I got it from Bug 936324 now.

The problem is in ril_worker.js, contact.id is undefined. So calling startsWith will cause TypeError. Previous in Bug 915987 could work because in RILContentHelper.js, mozContact.id is "undefined", (typeof(contact.id) = "string"), now since MozContact has been WebIDLized, so RILContentHelper.js receives undefined (typeof(contact.id) = "undefined"), so causes this bug. However even mozContact is WebIDLized, when running Marionette test, RILContentHelper still gets "undefined" (string) when reading contact.id. Will write a simple patch do check contact.id.

Comment on attachment 830127 [details] [diff] [review] Patch Review of attachment 830127 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/ril_worker.js @@ +918,5 @@ > } > > let contact = options.contact; > let iccid = RIL.iccInfo.iccid; > + if (typeof (contact.contactId) === "string" && nit: 'typeof' is an operator, just have |typeof foo === "string"|.

Filed the Marionette problem in Bug 937440

using typeof foo

try https://tbpl.mozilla.org/?tree=Try&rev=ccb2755be2da