Closed
Bug 936605
Opened 11 years ago
Closed 10 years ago
Ouija slave failures page should have a new column with a number that represents jobs since last success
Categories
(Testing :: General, defect)
Testing
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: kaustabh93, Mentored)
References
Details
this will help us determine if a machine is just running failures instead of a healthy mix of success, failures.
Assignee | ||
Comment 1•10 years ago
|
||
Hi,
I would like to work on this bug. But I am having a bit difficulty. Can you please tell me how to obtain the data? I mean how do I know which was the last success?
Thanks
Comment 2•10 years ago
|
||
Hi Kaustabh,
Please let me take a look and get some more details here for you.
Dan
Assignee: nobody → kaustabh93
Mentor: dminor
Status: NEW → ASSIGNED
Comment 3•10 years ago
|
||
The query to get the slave failure information is located here:
https://github.com/dminor/ouija/blob/master/src/server.py#L216
I think the first step is to change the query here:
https://github.com/dminor/ouija/blob/master/src/server.py#L233
to be 'order by date' rather than 'order by slave'. You might need to specify ascending or descending to get things working properly.
Then when you iterate over the results here:
https://github.com/dminor/ouija/blob/master/src/server.py#L248
You can keep a counter of number of failures e.g. data[slave]['jobs_since_last_success'] and reset it to 0 whenever you see a pass.
This data should then be available on the client and you can add it to an additional column in the results here: https://github.com/dminor/ouija/blob/master/static/js/slaves.js#L75
Please let me know if you have any further questions. Thanks!
Assignee | ||
Comment 4•10 years ago
|
||
Hey Dan,
I am working on this bug now. Can you please tell me how do I test whether my code is running properly or not? I mean how do I verify whether my results are correct or not?
Thanks
Assignee | ||
Comment 5•10 years ago
|
||
Hi,
I have created a pull request. Please review and verify the outputs.Plese do let me know of the results too.
Thanks.
Assignee | ||
Comment 6•10 years ago
|
||
Hi,
I have created a pull request. Please review and verify the outputs.Please do let me know of the results too.
Thanks.
Comment 7•10 years ago
|
||
(In reply to Kaustabh Datta Choudhury from comment #6)
> Hi,
> I have created a pull request. Please review and verify the
> outputs.Please do let me know of the results too.
>
> Thanks.
Hi Kaustabh,
Thanks! I should have a chance to look at this tomorrow morning.
Dan
Comment 8•10 years ago
|
||
(In reply to Kaustabh Datta Choudhury from comment #4)
> Hey Dan,
> I am working on this bug now. Can you please tell me how do I test
> whether my code is running properly or not? I mean how do I verify whether
> my results are correct or not?
>
> Thanks
Hi Kaustabh,
You can test your changes on your own system by following the setup instructions in the readme.md file. Let me know if you get stuck anywhere and I'll be happy to help out. I'm sure the instructions can use some improvement :)
Dan
Assignee | ||
Comment 9•10 years ago
|
||
Hey,
I had tested the changes in my own system. But I am not able to verify whether the results that are being produced are the expected results or not.
Thanks.
Comment 10•10 years ago
|
||
(In reply to Kaustabh Datta Choudhury from comment #9)
> Hey,
> I had tested the changes in my own system. But I am not able to verify
> whether the results that are being produced are the expected results or not.
>
> Thanks.
I've reviewed your pull request, there are a few small fixes needed, but otherwise, looks great!
Assignee | ||
Comment 11•10 years ago
|
||
Thanks Dan. I will definitely fix the issues.
Assignee | ||
Comment 12•10 years ago
|
||
Hey Dan,
I have fixed the issues. Please do have a look.
Thanks.
Assignee | ||
Comment 13•10 years ago
|
||
Hi Dan,
I have fixed the alignment issues. Please do have a look.
Thanks
Comment 14•10 years ago
|
||
Working great! Thanks for taking the time to look at this!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 15•10 years ago
|
||
Thanks a lot for giving me this opportunity.
Comment 16•10 years ago
|
||
(In reply to Kaustabh Datta Choudhury from comment #15)
> Thanks a lot for giving me this opportunity.
My pleasure. If you're interested in tackling another bug, take a look here:
https://github.com/jmaher/alert_manager/issues?state=open
The alert_manager and ouija are set up quite similarly. If you have any questions, just ask me or jmaher.
Thanks!
Dan
Assignee | ||
Comment 17•10 years ago
|
||
Thanks Dan. I will definitely look at it first thing tomorrow morning. ( it's midnight now over here)
Comment 18•10 years ago
|
||
(In reply to Kaustabh Datta Choudhury from comment #17)
> Thanks Dan. I will definitely look at it first thing tomorrow morning. (
> it's midnight now over here)
Sure, sounds good! I spoke with Joel and he recommended taking a look at one or both of these:
https://github.com/jmaher/alert_manager/issues/5
https://github.com/jmaher/alert_manager/issues/14
Assignee | ||
Comment 19•10 years ago
|
||
Hi Dan,
I have gone through the bugs that you listed. To begin with I would like to work on this : https://github.com/jmaher/alert_manager/issues/5 . Can you please tell me how to retrieve the data for this. On running alerts.html, all I am getting is a blank table with provisions to select some filters but no data is being showed.
Thanks.
Comment 20•10 years ago
|
||
(In reply to Kaustabh Datta Choudhury from comment #19)
> Hi Dan,
> I have gone through the bugs that you listed. To begin with I would
> like to work on this : https://github.com/jmaher/alert_manager/issues/5 .
> Can you please tell me how to retrieve the data for this. On running
> alerts.html, all I am getting is a blank table with provisions to select
> some filters but no data is being showed.
>
> Thanks.
Hi Kaustabh,
I've add some sample data and improved the project readme today, so things should be easier to run locally. Please let me know if you're still running into problems.
Thanks,
Dan
You need to log in
before you can comment on or make changes to this bug.
Description
•