Closed
Bug 937005
Opened 11 years ago
Closed 11 years ago
Xulrunner 26 unresolved external symbol __imp__PR_sscanf
Categories
(Toolkit Graveyard :: XULRunner, defect)
Tracking
(firefox26 verified, firefox27 verified, firefox28 verified, b2g-v1.2 wontfix)
VERIFIED
FIXED
mozilla28
People
(Reporter: mohd.rozi.zafar, Assigned: glandium)
References
Details
Attachments
(3 files)
(deleted),
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
lsblakk
:
approval-mozilla-aurora+
lsblakk
:
approval-mozilla-beta+
lsblakk
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/29.0.1547.76 Safari/537.36
Steps to reproduce:
1) Download Xulrunner SDK from http://ftp.mozilla.org/pub/mozilla.org/xulrunner/releases/26.0b3/sdk/xulrunner-26.0b3.en-US.win32.sdk.zip
Actual results:
nss3.lib is missing in xulrunner 26
Below is a compiler output (VS2010) :
xpcomglue_s_nomozalloc.lib(nsStringAPI.obj) : error LNK2001: unresolved external symbol __imp__PR_sscanf
xpcomglue_s_nomozalloc.lib(nsCRTGlue.obj) : error LNK2001: unresolved external symbol __imp__PR_Now
C:\26litmus-ff .dll : fatal error LNK1120: 2 unresolved externals
Expected results:
Program should compiled OK using latest SDK (xulrunner 26)
Comment 1•11 years ago
|
||
It's true that the SDK doesn't seem to contain a nss3.lib files which is where these NSPR functions should be present.
Glandium, thoughts?
Flags: needinfo?(mh+mozilla)
Assignee | ||
Comment 2•11 years ago
|
||
It means we have a missing SDK_LIBRARY definition in security/build/Makefile.in
Flags: needinfo?(mh+mozilla)
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #830440 -
Flags: review?(benjamin)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → mh+mozilla
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Updated•11 years ago
|
Attachment #830440 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Comment 7•11 years ago
|
||
does mozilla28 mean that you intend to apply this fix to xulrunner 28 at the earliest?
That what be a real pain for all who relay on the sdks to be complete.
Comment 8•11 years ago
|
||
It means that it's fixed for the Firefox 28 release (which we'll ship a Xulrunner 28 alongside). If no other action is taken, that's the earliest the fix will ship.
This patch is pretty simple, we could probably take it on an earlier release to fix the problem. glandium: do you want to try to get this on aurora/beta?
Flags: needinfo?(mh+mozilla)
Assignee | ||
Comment 9•11 years ago
|
||
Turns out this is also not actually fixed.
Status: RESOLVED → REOPENED
Flags: needinfo?(mh+mozilla)
Resolution: FIXED → ---
Assignee | ||
Comment 10•11 years ago
|
||
Attachment #8341967 -
Flags: review?(ted)
Updated•11 years ago
|
Attachment #8341967 -
Flags: review?(ted) → review+
Assignee | ||
Comment 11•11 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 12•11 years ago
|
||
This is the combined patch for branches.
Assignee | ||
Comment 13•11 years ago
|
||
Comment on attachment 8342108 [details] [diff] [review]
Install folded import library in the SDK.
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 648407
User impact if declined: Impossible to build binary components for firefox on windows with the SDK.
Testing completed (on m-c, etc.): Landed actual fix on m-c today, got a xulrunner nightly triggered, and verified the SDK contents.
Risk to taking this patch (and alternatives if risky): The patch only makes us copy one more file to dist/sdk during the build. This doesn't affect the resulting firefox builds. The only thing this affects is the SDK we create on xulrunner builds. It's probably too late on beta for firefox, but maybe it's not for xulrunner?
String or IDL/UUID changes made by this patch: None
Attachment #8342108 -
Flags: approval-mozilla-beta?
Attachment #8342108 -
Flags: approval-mozilla-aurora?
Comment 14•11 years ago
|
||
Comment on attachment 8342108 [details] [diff] [review]
Install folded import library in the SDK.
[Triage Comment]
Since this does not affect builds, please go ahead with uplift but also uplift to mozilla-release branch so that, if necessary, it's in any respins for 26.0
Attachment #8342108 -
Flags: approval-mozilla-release+
Attachment #8342108 -
Flags: approval-mozilla-beta?
Attachment #8342108 -
Flags: approval-mozilla-beta+
Attachment #8342108 -
Flags: approval-mozilla-aurora?
Attachment #8342108 -
Flags: approval-mozilla-aurora+
Comment 15•11 years ago
|
||
If it's just that the library is missing, would copying nss3.lib from 25.0.1 be a reasonable way to get it to build?
Assignee | ||
Comment 16•11 years ago
|
||
Likely not.
Comment 17•11 years ago
|
||
Hmm, I tried it and my plugin builds and runs, so far.
Comment 18•11 years ago
|
||
The same issue happens on the Mac. I created a separate bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=946558
Assignee | ||
Comment 20•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/21ef58290c6a
https://hg.mozilla.org/releases/mozilla-release/rev/e72dc12f4eaf
beta is closed, and i /think/ it's fine not to land there, since aurora, which now has it will be merged there, and nothing is supposed to happen on beta before that.
Not sure how to update the status flags, considering it may or may not make it to 26.
status-firefox27:
--- → fixed
Comment 21•11 years ago
|
||
Does this need to land on b2g26?
Assignee | ||
Comment 22•11 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #21)
> Does this need to land on b2g26?
No
Flags: needinfo?(mh+mozilla)
Updated•11 years ago
|
status-b2g-v1.2:
--- → wontfix
Comment 23•11 years ago
|
||
Mohd Rozi, please confirm this is fixed for you now in Firefox 28 (aurora), Firefox 27 (beta), and Firefox 26 (release)
Flags: needinfo?(mohd.rozi.zafar)
Reporter | ||
Comment 24•11 years ago
|
||
Yes, confirmed. Everything is OK now.
Updated•9 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•