Closed
Bug 937289
Opened 11 years ago
Closed 11 years ago
[Settings] Remove keyboard_helper from startup path
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
(Keywords: perf, Whiteboard: [c= p=2 s=2013.11.22 u=])
Attachments
(1 file)
It looks like we've added the keyboard helper into the settings startup path, and I don't think it should be. The only reason it should be there is if something in the root panel needs it, and if so - we should do it on an idle timer. Added in this commit: https://github.com/mozilla-b2g/gaia/commit/a2690f364fde0d11f83a9b773e55b9e4eca85403#diff-f36e65bf103d8ff227c8349e0411b107R659
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 830394 [details]
Github pull request pointer
Hey - looking for a review here. Moving this into the language panel should be fine as that should be the only place language.current should be changed within the settings app.
Thanks!
Attachment #830394 -
Flags: review?(rlu)
Attachment #830394 -
Flags: review?(arthur.chen)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 830394 [details]
Github pull request pointer
This fine-tuning looks good to me.
Kevin, thanks a lot.
Attachment #830394 -
Flags: review?(rlu) → feedback+
|
||
Comment 4•11 years ago
|
||
Comment on attachment 830394 [details]
Github pull request pointer
Thanks! r=me with the comment addressed.
Attachment #830394 -
Flags: review?(arthur.chen) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Thanks for the quick review! Landed in master: https://github.com/mozilla-b2g/gaia/commit/485c7b644f656126a6e8a336b93529f8f62ff41e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Whiteboard: [c= p=2 s= u=] → [c= p=2 s=2013.11.22 u=]
You need to log in
before you can comment on or make changes to this bug.
Description
•