Closed
Bug 937487
Opened 11 years ago
Closed 11 years ago
Keyboard won't disappear after focusing an input and then launch an activity
Categories
(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)
Tracking
(blocking-b2g:1.3+, b2g-v1.3 fixed)
People
(Reporter: rudyl, Assigned: GaryChen)
References
Details
Attachments
(2 files)
This is created as a follow-up bug of Bug 934449.
I have created a really simple test case here,
https://github.com/RudyLu/gaia/commit/57354b0253c9c65713ce4ed9dff1a1c40dd34b7d
, which will focus an input and then call the "pick contact" activity.
On v1.1, the keyboard would disappear after a while the new activity is loaded, but not on current Gaia master.
Reporter | ||
Comment 1•11 years ago
|
||
Hi Alive,
Do you happen to know if we have changed anything about focus after launching an activity?
Thanks.
Flags: needinfo?(alive)
Reporter | ||
Comment 2•11 years ago
|
||
Also ni Gary to see if he's interested in taking a look.
Flags: needinfo?(gchen)
Comment 3•11 years ago
|
||
I think we should blur / focus when inlineActivity is launched/killed but I don't why we don't in current master.
Flags: needinfo?(alive)
Assignee | ||
Comment 4•11 years ago
|
||
Hi Rudy,
I'll take a look.
Assignee: nobody → gchen
Flags: needinfo?(gchen)
Comment 5•11 years ago
|
||
Well, should throw a blur event from platform. Gary, can you verify whether that happens?
Comment 6•11 years ago
|
||
Any update?
Thanks!
Assignee | ||
Comment 7•11 years ago
|
||
Hi Alive,
please help to review this patch.
Adding 'activitywillopen' and 'activitywillclose' event handler.
Thanks.
Attachment #8349890 -
Flags: review?(alive)
Comment 8•11 years ago
|
||
Comment on attachment 8349890 [details]
pull request: https://github.com/mozilla-b2g/gaia/pull/14831
r+ if use new event name
Attachment #8349890 -
Flags: review?(alive) → review+
Assignee | ||
Comment 9•11 years ago
|
||
Thanks Alive,
I've addressed your comment
https://github.com/mozilla-b2g/gaia/pull/14831/files
Travis passed:
https://travis-ci.org/mozilla-b2g/gaia/builds/15692845
land in master:
https://github.com/mpizza/gaia/commit/3364f21ad0987bb327d39ed2a9e46aeceed65b84
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 10•11 years ago
|
||
Gaia master hash is: e8dfed06a8524c0d72c0c96c83341562754164fc
Comment 11•11 years ago
|
||
Gary, alive, would it be easy to uplift this in 1.3? Should we request an approval?
Updated•11 years ago
|
Flags: needinfo?(gchen)
Flags: needinfo?(alive)
Comment 12•11 years ago
|
||
Yes, activity* event comes from ActivityWindow which is also in 1.3
Flags: needinfo?(alive)
Assignee | ||
Comment 13•11 years ago
|
||
Hi Ivan,
I've set this issue to v1.3?.
Should we uplift this issue to v1.3 after being nominated v1.3+ ?
Flags: needinfo?(gchen) → needinfo?(itsay)
Comment 15•11 years ago
|
||
Thanks!
I just duped another consequence of this bug here then :)
Comment 16•11 years ago
|
||
(In reply to GaryChen [:GaryChen][:PYChen] from comment #13)
> Hi Ivan,
> I've set this issue to v1.3?.
> Should we uplift this issue to v1.3 after being nominated v1.3+ ?
I promoted this to v1.3+ based on comment 12 because this one looks to me the regression and the fix should be in v1.3 as well.
blocking-b2g: --- → 1.3+
Flags: needinfo?(itsay)
Comment 17•11 years ago
|
||
I was not able to uplift this bug to v1.3. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1.3, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with:
git checkout v1.3
git cherry-pick -x -m1 e8dfed06a8524c0d72c0c96c83341562754164fc
<RESOLVE MERGE CONFLICTS>
git commit
Flags: needinfo?(gchen)
Assignee | ||
Comment 18•11 years ago
|
||
travis passed:
https://travis-ci.org/mozilla-b2g/gaia/jobs/16908216#
landed in v1.3:
https://github.com/mpizza/gaia/commit/984223b294384d7c512755f395dc5f0bb9665455
status-b2g-v1.3:
--- → fixed
Flags: needinfo?(gchen)
Reporter | ||
Updated•11 years ago
|
Component: Gaia::Keyboard → Gaia::System::Input Mgmt
Assignee | ||
Comment 20•11 years ago
|
||
revert it first, I make some mistake here.
https://github.com/mozilla-b2g/gaia/commit/a81ccdc53e45a6adeaae423e104e91bcc1e12b0e
Comment 21•11 years ago
|
||
Thanks for digging out this problem and passed the information.
We (Taipei QA) are participating in QA workweek (1/12~1/17). So we still don't have time to verify it.
We will verify it in a few days.
Thanks.
Assignee | ||
Updated•11 years ago
|
Assignee | ||
Comment 22•11 years ago
|
||
Hi Alive,
Please help to review this v1.3 patch.
Thanks.
Attachment #8361745 -
Flags: review?(alive)
Updated•11 years ago
|
Attachment #8361745 -
Flags: review?(alive) → review+
Assignee | ||
Comment 23•11 years ago
|
||
travis passed:
https://travis-ci.org/mozilla-b2g/gaia/builds/17259371
patch landed in v1.3:
https://github.com/mpizza/gaia/commit/21a23f8386bf997bcda3b9c8da23593f044c2055
Comment 25•11 years ago
|
||
Thanks for the help!
I cannot reproduce the bug that comment 20 mentioned. Verified it.
* Verified Build: (Device -> Buri)
- Gaia 47049555282a9a01fb60d1e1421b57e2810c96f5
- Gecko http://hg.mozilla.org/releases/mozilla-aurora/rev/6f7dfe36ab6c
- BuildID 20140121004137
- Version 28.0a2
* Result:
- Cannot reproduce it.
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•