Closed
Bug 937734
Opened 11 years ago
Closed 11 years ago
Adjust height of navbar to 40px per Australis specs on OS X
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 31
People
(Reporter: jaws, Assigned: brandon.cheng)
References
()
Details
(Whiteboard: [Australis:P4][fixed by bug 893661][qa-])
+++ This bug was initially created as a clone of Bug #873626 +++
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:21.0) Gecko/20100101 Firefox/21.0 (Beta/Release)
Build ID: 20130512193902
Steps to reproduce:
The specifications from Stephen Horlander call for a 40px tall navigation bar. It is currently 36px.
http://people.mozilla.com/~shorlander/files/australis-designSpecs/australis-designSpecs-windows7-mainWindow.html#sectionNavBar
--------------------
Bug 873626 fixed this for Linux and Windows, but not OS X. Brandon, can you work on this?
Flags: needinfo?(bcheng.gt)
Assignee | ||
Comment 1•11 years ago
|
||
(In reply to Jared Wein [:jaws] from comment #0)
> Bug 873626 fixed this for Linux and Windows, but not OS X. Brandon, can you
> work on this?
Love to. There's some proportion issues with OS X that I mentioned back in bug 873626 comment 21. Is bug 893661 is where we're tracking that?
Flags: needinfo?(bcheng.gt)
Reporter | ||
Comment 2•11 years ago
|
||
Yeah, the proportion issue is tracked in bug 893661, but if the proportion issue needs to be fixed before this one then maybe you could take that bug as well?
Assignee: nobody → bcheng.gt
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Jared Wein [:jaws] from comment #2)
> Yeah, the proportion issue is tracked in bug 893661, but if the proportion
> issue needs to be fixed before this one then maybe you could take that bug
> as well?
I made a comment on bug 893661. :)
Updated•11 years ago
|
Whiteboard: [Australis:M?][Australis:P4] → [Australis:P4]
Assignee | ||
Comment 4•11 years ago
|
||
Just to keep updates. Fixing bug 873626 also fixes this one inadvertently.
Reporter | ||
Comment 5•11 years ago
|
||
Thanks, closing now.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P4] → [Australis:P4][fixed by bug 873626]
Reporter | ||
Comment 6•11 years ago
|
||
Actually, those patches in bug 873626 were only for Linux and Windows themes. Are you saying that the same approach as those patches can be taken for OSX?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [Australis:P4][fixed by bug 873626] → [Australis:P4]
Assignee | ||
Comment 7•11 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #6)
> Actually, those patches in bug 873626 were only for Linux and Windows
> themes. Are you saying that the same approach as those patches can be taken
> for OSX?
Whoops. I'm sorry for the confusion. I copied and pasted the wrong bug number. The WIP of Bug 893661 fixes it as the back button stretches the nav-bar 2px.
Comment 8•11 years ago
|
||
This should be fixed per bug 893661.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
status-firefox29:
--- → affected
status-firefox30:
--- → affected
status-firefox31:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
Reporter | ||
Updated•11 years ago
|
Whiteboard: [Australis:P4] → [Australis:P4][fixed by bug 893661]
Reporter | ||
Updated•11 years ago
|
Updated•11 years ago
|
Whiteboard: [Australis:P4][fixed by bug 893661] → [Australis:P4][fixed by bug 893661][qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•