Peter Bylenga [:PBylenga] Reporter
	Description • 11 years ago

Description:
When Bulgarian is selected as a Built-in Keyboard, there will not be any auto correction feature.

Repro Steps:
1) Updated Buri to Build ID: 20131112004004
2) Navigate to Settings App
3) Navigate into Keyboards and tap Selected Keyboards
4) Tap on Add more keyboards and select Bulgarian
5) Tap '<' button to go back to Keyboards menu
6) Tap on Built-in Keyboard and verify Auto correction box and Word suggestion are checked
7) Return to Homescreen
8) Open Messages App
9) Tap into Message field to bring up keyboard 
10) Long press on globe icon next to the space bar to bring up keyboard Layout selection
11) Select Built-in Keyboard Bulgarian
12) Begin typing and observe

Actual:
Auto-Correction and Word Suggestion options are not presented to the user.

Expected:
Auto-Correction and Word Suggestion options are presented to the user.

Environmental Variables
Device: Buri v1.2 COM RIL
Build ID: 20131112004004
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/566e850868c7
Gaia: N/A
Platform Version: 26.0
RIL Version: 01.02.00.019.106 
Firmware Version: US_20131104

Notes:
Repro frequency: 5/5, 100%
See attached: screenshots

	Axel Hecht [:Pike]
	Comment 1 • 11 years ago

Yep, there's no dictionary in the tree. CCing Kevin in case we need his help with one.

	Delphine Lebédel [:delphine - Off until Sept 19]
	Comment 2 • 11 years ago

asking for koi+ as it's a shipping locale

	Tim Guan-tin Chien [:timdream] (please needinfo)
	Comment 3 • 11 years ago

David, is this something you could help?

	Jason Smith [:jsmith]
	Comment 4 • 11 years ago

Blocking on this - required for a target 1.2 locale

	David Flanagan [:djf] Assignee
	Comment 5 • 11 years ago

Kevin prepared a Bulgarian word list for us back in August when we told him we needed it for 1.1.  Then we found out we didn't need it and we never checked it in (this was before we had configurable keyboard builds).

Now the link to Kevin's server is down.  I'll email him and hope he can re-send it soon.

	David Flanagan [:djf] Assignee
	Comment 6 • 11 years ago

Kevin was able to recreated his wordlist trivially.  This pull request adds the wordlist and dictionary to keyboard/dictionaries and updates keyboard/layouts/bg.js to point to it.

Note that you still have to create a build that includes the bulgarian layout in order to get it working.  But if you do that, it seems to work.

Axel: if you're not an appropriate reviewer, maybe you could forward the review to Tim.

	Axel Hecht [:Pike]
	Comment 7 • 11 years ago

Comment on attachment 8336345 [details]
link to patch on github

For most things gaia, I'm not a good reviewer. Moving the request over to Tim.

	Tim Guan-tin Chien [:timdream] (please needinfo)
	Comment 8 • 11 years ago

Comment on attachment 8336345 [details]
link to patch on github

Thanks!

	Tim Guan-tin Chien [:timdream] (please needinfo)
	Comment 9 • 11 years ago

master: https://github.com/mozilla-b2g/gaia/commit/1cd5bef43a577ef2256a048269a4926c0f492470

	John Ford [:jhford] CET/CEST Berlin Time
	Comment 10 • 11 years ago

Uplifted 1cd5bef43a577ef2256a048269a4926c0f492470 to:
v1.2: 9d59dbb1d33fc958794fb8c1a8231f4c7671d362

	Roland Kunkel [:RolandK]
	Comment 11 • 11 years ago

Running through the Auto-correction suite in the Localization Screen Pass, the  Auto correction and Word suggestion for Bulgarian appear to be working as intended. Verifying as fixed. 

Here are the environment variables of the device used to test.

Environmental Variables
Device: Buri v1.2 COM RIL
Build ID: 20131203004002
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/244e98241b2c
Gaia: N/A
Platform Version: 26.0
RIL Version: 01.02.00.019.102 
Firmware Version: V1.2_US_20131115

	Roland Kunkel [:RolandK]
	Comment 12 • 11 years ago

Updating tracking flag to verified.