Closed
Bug 938007
Opened 11 years ago
Closed 11 years ago
Wrapper's footer close button is incorrectly screen-reader accessible.
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: yzen, Assigned: yzen)
References
Details
(Keywords: access)
Attachments
(1 file)
It looks like the close button's visibility is set to visible when the footer is closed and to hidden when the footer is opened.
Assignee | ||
Comment 1•11 years ago
|
||
Hi, I was wondering if there was a reason the close button was shown on closed footer.
Flags: needinfo?(gasolin)
Summary: Wrapper's close button is incorrectly screen-reader accessible. → Wrapper's footer close button is incorrectly screen-reader accessible.
Comment 2•11 years ago
|
||
Yura, can you upload the screenshot, or have some description about the current / expect behavior of this issue?
Flags: needinfo?(gasolin)
Comment 3•11 years ago
|
||
I just get what the issue means. Its a bug if close button shown in a closed footer
Assignee | ||
Comment 4•11 years ago
|
||
Hi Fred, so the issue with the screen reader is that by default when homegesture.enabled is false, close button's visibility is set to visible (even though the footer is closed and not visible). This results in the close button being announced by the screen reader which is incorrect in case where it's not actually shown to the sighted user. As far as I understand, close button should only be visible when the wrapper footer is not closed and is visible, is that right? So I guess, I was wondering if handling visibility of the close button specifically on homegesture.enabled change is necessary?
Comment 5•11 years ago
|
||
Thanks for finding this, yes we still need to set the visibility to make sure the result is correct while developer switch the homegesture option, or the close button will always hidden after toggle the homegesture option. But its more reasonable to put the close_button.style.visibility part into the footer.classList.contains('closed') part, thus the close button visibility is fully related to footer's state.
Assignee | ||
Comment 6•11 years ago
|
||
Thanks, I will go ahead with the change then!
Assignee | ||
Comment 7•11 years ago
|
||
(In reply to Fred Lin [:gasolin] from comment #5) > Thanks for finding this, yes we still need to set the visibility to make > sure the result is correct while developer switch the homegesture option, or > the close button will always hidden after toggle the homegesture option. > Actually, I was wondering if the visibility of the close button is not set at all, it will be visible if the footer is not closed since we control the visibility of the whole footer?
Comment 8•11 years ago
|
||
just take a try and have a patch for it :)
Assignee | ||
Comment 9•11 years ago
|
||
Attachment #832016 -
Flags: review?(gasolin)
Comment 10•11 years ago
|
||
Comment on attachment 832016 [details] Pull request for 938007 When home gesture is enabled, the close icon should always be hidden and the footbar will always open. BTW, please ask review? to alive@mozilla.com since he is the right module owner (reviewer)
Attachment #832016 -
Flags: review?(gasolin) → review-
Assignee | ||
Updated•11 years ago
|
Attachment #832016 -
Flags: review- → review?(alive)
Assignee | ||
Comment 11•11 years ago
|
||
Updated the pull request, preserving the functionality mentioned by Fred.
Updated•11 years ago
|
Blocks: app-window-manager
Updated•11 years ago
|
Attachment #832016 -
Flags: review?(alive) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 12•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/049a03da269e493e4afc9765ad5f06981145d05d
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Keywords: checkin-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•