Closed
Bug 938071
Opened 11 years ago
Closed 11 years ago
Typo in TabState.onSwapDocShells()
Categories
(Firefox :: Session Restore, defect)
Firefox
Session Restore
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
(deleted),
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
> this._syncHandlers.set(browser, otherHandler);
> this._syncHandlers.set(otherHandler, handler);
should be:
> this._syncHandlers.set(browser, otherHandler);
> this._syncHandlers.set(otherBrowser, handler);
|
Assignee | |
Comment 1•11 years ago
|
||
I tried to write a test for this but so far otherBrowser is always the browser that is thrown away in all our use cases. So no easy testing without relying on "private" tabbrowser methods.
Attachment #831428 -
Flags: review?(wmccloskey)
Attachment #831428 -
Flags: review?(wmccloskey) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
Whiteboard: [fixed-in-fx-team]
|
||
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•