Closed
Bug 938189
Opened 11 years ago
Closed 11 years ago
Avoid duplicate snapshot taking and compression during a history swipe animation
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: spohl, Assigned: spohl)
References
Details
Attachments
(2 files, 4 obsolete files)
(deleted),
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
We mistakenly used to take a snapshot and compress it when we started a swipe animation and again when we were just about to navigate away from the current page. This separates the two steps of snapshotting and compression and only does them once per animation.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #831585 -
Flags: review?(felipc)
Updated•11 years ago
|
Attachment #831585 -
Flags: review?(felipc) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #831635 -
Flags: review?(felipc)
Assignee | ||
Comment 3•11 years ago
|
||
Updated to apply over new patches in bug 836430. Carrying over r+.
Attachment #831585 -
Attachment is obsolete: true
Attachment #831981 -
Flags: review+
Assignee | ||
Comment 4•11 years ago
|
||
Updated to apply over new patches in bug 836430. Carrying over r?.
Attachment #831635 -
Attachment is obsolete: true
Attachment #831635 -
Flags: review?(felipc)
Attachment #831982 -
Flags: review?
Assignee | ||
Comment 5•11 years ago
|
||
Sent to try, along with the patches in bug 836430:
https://tbpl.mozilla.org/?tree=Try&rev=006bb18afe21
Assignee | ||
Updated•11 years ago
|
Attachment #831982 -
Flags: review?
Assignee | ||
Comment 6•11 years ago
|
||
b-c tests failed in the try run. :mikedeboer was kind enough to point out to me that I forgot about the early return at the beginning of 'HSA__takeSnapshot'. When a tab first opens, the history index is -1 which would lead to an early return and leave gBrowser.selectedBrowser.snapshots uninitialized. However, we would then try to retrieve it in 'HSA__compressSnapshotAtCurrentIndex', which leads to the errors in b-c. This patch here is green on try:
https://tbpl.mozilla.org/?tree=Try&rev=a8d1dcbc78f0
Attachment #831981 -
Attachment is obsolete: true
Attachment #832359 -
Flags: review?(felipc)
Assignee | ||
Comment 7•11 years ago
|
||
Updated for new patch. Setting back to r?.
Attachment #831982 -
Attachment is obsolete: true
Attachment #832360 -
Flags: review?(felipc)
Updated•11 years ago
|
Attachment #832359 -
Flags: review?(felipc) → review+
Updated•11 years ago
|
Attachment #832360 -
Flags: review?(felipc) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 8•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ecbe700f096
https://hg.mozilla.org/integration/mozilla-inbound/rev/34ffe646812e
Keywords: checkin-needed
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7ecbe700f096
https://hg.mozilla.org/mozilla-central/rev/34ffe646812e
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•