Closed Bug 938388 Opened 11 years ago Closed 11 years ago

Convert all remaining code for calculating path lengths and position at an offset along a path in content/svg to Moz2D (kill off all uses of gfxPath)

Categories

(Core :: SVG, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: jwatt, Assigned: jwatt)

References

(Blocks 1 open bug)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Following on from bug 934305, this patch converts all remaining path handling in content/svg to Moz2D.
Attached patch patch (deleted) — Splinter Review
Attachment #831863 - Flags: review?(dholbert)
Summary: Convert all remaining path handling in content/svg to Moz2D (kill off all uses of gfxPath) → Convert all remaining code for calculating path lengths and position at an offset along a path in content/svg to Moz2D (kill off all uses of gfxPath)
Blocks: 926258
Depends on: 935049
Comment on attachment 831863 [details] [diff] [review] patch >+++ b/content/svg/content/src/SVGMotionSMILAnimationFunction.h >+ PathSourceType mPathSourceType; // source of our Path. >+ mozilla::RefPtr<Path> mPath; // representation of motion path. > nsTArray<double> mPathVertices; // distances of vertices along path. > > bool mIsPathStale; > }; > > } // namespace mozilla I don't think we need the "mozilla::" prefix there, since this code is inside of namespace mozilla {}, right? >+++ b/content/svg/content/src/SVGMotionSMILPathUtils.cpp >-already_AddRefed<gfxPath> >+TemporaryRef<Path> > SVGMotionSMILPathUtils::PathGenerator::GetResultingPath() > { > RefPtr<Path> path = mPathBuilder->Finish(); >- nsRefPtr<gfxPath> thebesPath = new gfxPath(path); >- return thebesPath.forget(); >+ return path.forget(); > } No need for the |path| local-var here anymore. We can just directly return mPathBuilder->Finish() (making this a one-liner). r=me
Attachment #831863 - Flags: review?(dholbert) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: