Closed
Bug 938544
Opened 11 years ago
Closed 11 years ago
Add support for a Chrome-only constructor in WebIDL
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: peterv, Assigned: peterv)
References
()
Details
(Whiteboard: [qa-])
Attachments
(1 file)
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
For now we'll just support having either non-Chrome-only or Chrome-only constructors, not both at the same time. We'd have to generate separate constructors if we ever do (and make Xrays support them etc).
Attachment #832150 -
Flags: review?(bzbarsky)
Comment 1•11 years ago
|
||
Comment on attachment 832150 [details] [diff] [review]
v1
Review of attachment 832150 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/bindings/Codegen.py
@@ +2223,2 @@
> """
> object is the name of a JSObject*
Maybe document context too
Comment 2•11 years ago
|
||
Comment on attachment 832150 [details] [diff] [review]
v1
> + }""" % GetAccessCheck(self.descriptor, "cx", "obj")
I think you want a linebreak before the """ here.
r=me with the comments ms2ger asked for.
What actually ends up preventing having both a [Constructor(), ChromeConstructor()] situation, by the way?
Attachment #832150 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e36faba57f46
(In reply to Boris Zbarsky [:bz] from comment #2)
> What actually ends up preventing having both a [Constructor(),
> ChromeConstructor()] situation, by the way?
We check for differing extended attributes on overloads.
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Comment 5•11 years ago
|
||
Peter, can you please document this at https://developer.mozilla.org/en/Mozilla/WebIDL_bindings ?
Flags: needinfo?(peterv)
Keywords: dev-doc-needed
Updated•11 years ago
|
Whiteboard: [qa-]
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(peterv)
Assignee | ||
Updated•10 years ago
|
Keywords: dev-doc-needed
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•